Re: [PATCH 1/2] ARM: dts: r8a7790: Add SATA nodes to r8a7790.dtsi

[Valentine <valentine.barshak@cogentembedded.com>]

On 01/14/2014 09:23 PM, Laurent Pinchart wrote:
> Hi Valentine,
>
> Thank you for the patch.
>
> On Tuesday 14 January 2014 21:05:30 Valentine Barshak wrote:
>> This adds SATA[01] device nodes to r8a7790.dtsi
>>
>> Signed-off-by: Valentine Barshak <valentine.barshak@cogentembedded.com>
>> ---
>>   arch/arm/boot/dts/r8a7790.dtsi | 18 ++++++++++++++++++
>>   1 file changed, 18 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
>> index b2c2845..f2f5394 100644
>> --- a/arch/arm/boot/dts/r8a7790.dtsi
>> +++ b/arch/arm/boot/dts/r8a7790.dtsi
>> @@ -400,6 +400,24 @@
>>   		status = "disabled";
>>   	};
>>
>> +	sata0: sata@ee300000 {
>> +		compatible = "renesas,sata-r8a7790";
>> +		reg = <0 0xee300000 0 0x2000>;
>> +		interrupt-parent = <&gic>;
>> +		interrupts = <0 105 IRQ_TYPE_LEVEL_HIGH>;
>> +		clocks = <&mstp8_clks R8A7790_CLK_SATA0>;
>
> If I'm not mistaken the RCar SATA DT bindings don't document the clocks
> property.

Yes, they don't, cause at that time the clocks were not supported.

> Could you please submit a patch to fix that ?

I could, but the patch that adds the description is still available only
in the for-3.14 branch of the libata repo.
The other thing is that the clocks are not yet included in the r8a7779.dtsi,
a snippet from which is used as an example of SATA bindings.

So we probably have to wait until both are available in 3.14.

Thanks,
Val.

>
> There's no need to delay this patch set.
> for-3.14
>> +		status = "disabled";
>> +	};
>> +
>> +	sata1: sata@ee500000 {
>> +		compatible = "renesas,sata-r8a7790";
>> +		reg = <0 0xee500000 0 0x2000>;
>> +		interrupt-parent = <&gic>;
>> +		interrupts = <0 106 IRQ_TYPE_LEVEL_HIGH>;
>> +		clocks = <&mstp8_clks R8A7790_CLK_SATA1>;
>> +		status = "disabled";
>> +	};
>> +
>>   	clocks {
>>   		#address-cells = <2>;
>>   		#size-cells = <2>;