From: Ben Dooks <ben.dooks@codethink.co.uk>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: r8a7790: add i2c[0-3] clocks
Date: Mon, 20 Jan 2014 10:51:28 +0000 [thread overview]
Message-ID: <52DCFFB0.1020804@codethink.co.uk> (raw)
In-Reply-To: <1389974082-27677-1-git-send-email-ben.dooks@codethink.co.uk>
On 19/01/14 11:03, Laurent Pinchart wrote:
> Hi Ben,
>
> Thank you for the patch.
>
> On Friday 17 January 2014 15:54:42 Ben Dooks wrote:
>> Add the necessary clocks for i2c0 to i2c3 into the mstp3 clock node. This
>> is a pre-cursor to adding the i2c devices themslves.
>
> According to the R8A7790 datasheet the I2C MSTP clocks are handled by MSTP9,
> not MSTP3, and they're already declared in the MSTP9 DT node.
Ah, the i2cX nodes themselves are wrong.
i2c1: i2c@e6518000 {
#address-cells = <1>;
#size-cells = <0>;
compatible = "renesas,i2c-r8a7790";
reg = <0 0xe6518000 0 0x40>;
interrupt-parent = <&gic>;
interrupts = <0 288 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&mstp3_clks R8A7790_CLK_I2C1>;
status = "disabled";
};
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2014-01-20 10:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 15:54 [PATCH] ARM: shmobile: r8a7790: add i2c[0-3] clocks Ben Dooks
2014-01-19 11:03 ` Laurent Pinchart
2014-01-20 10:51 ` Ben Dooks [this message]
2014-01-20 10:55 ` Laurent Pinchart
2014-01-20 10:58 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DCFFB0.1020804@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).