From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Dooks Date: Mon, 27 Jan 2014 13:33:30 +0000 Subject: Re: [PATCH 2/8] pci-rcar-gen2: add initial device tree documentation Message-Id: <52E6602A.8040003@codethink.co.uk> List-Id: References: <1390754945-28142-1-git-send-email-ben.dooks@codethink.co.uk> <1390754945-28142-3-git-send-email-ben.dooks@codethink.co.uk> <52E65F95.9080306@cogentembedded.com> In-Reply-To: <52E65F95.9080306@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sergei Shtylyov Cc: Geert Uytterhoeven , linux-kernel@lists.codethink.co.uk, Linux-sh list , "devicetree@vger.kernel.org" , horms+renesas@verge.net.au On 27/01/14 13:31, Sergei Shtylyov wrote: > Hello. > > On 26-01-2014 23:09, Geert Uytterhoeven wrote: > >>> + - reg : A list of physical regions to access the device. The first is >>> + the operational registers for the OHCI/EHCI controller and the >>> + second region is for the bridge configuration and control >>> registers. > >> You may want to add "reg-names" to use named regions, as there >> is more than one region. > > I've already told Ben he can't claim EHCI/OHCI register ranges at > the bridge node, so there should be only one "reg" specifier. Well, that's going to take quite a bit of changing the driver as it already assumes two nodes from the platform device definition. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius