From: Ben Dooks <ben.dooks@codethink.co.uk>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 04/11] ARM: shmobile: lager.dts: add pci 0/1/2
Date: Wed, 05 Feb 2014 12:13:47 +0000 [thread overview]
Message-ID: <52F22AFB.704@codethink.co.uk> (raw)
In-Reply-To: <1391595554-20640-5-git-send-email-ben.dooks@codethink.co.uk>
On 05/02/14 12:09, Magnus Damm wrote:
> On Wed, Feb 5, 2014 at 7:19 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>> Enable pci1 and pci2 nodes for USB controllers attached to the AHB<>PCI
>> bridge devices. Node pci0 is enabled for the moment as a device, but
>> could be switched to usb-gadget mode later.
>>
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>> Reviewed-by: Ian Molton <ian.molton@codethink.co.uk>
>
> I'd like this to follow board-lager.c, which means using usb0 as
> gadget-only due to missing cable detection on the micro-USB connector.
> So feel free to keep pci0, pci1, pci2 in r8a7790.dtsi but for
> r8a7790-lager.dtsi please omit pci0 to keep in-sync with the legacy
> board-lager.c code.
Thanks, I'd missed that there was no A/B detection on the
socket.
Can I add the pci0 to the r8a7790.dtsi as we need it for our
project? I will update the lager dts file to set channel 0
to be used as the device.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2014-02-05 12:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 10:19 [PATCH 04/11] ARM: shmobile: lager.dts: add pci 0/1/2 Ben Dooks
2014-02-05 12:09 ` Magnus Damm
2014-02-05 12:13 ` Ben Dooks [this message]
2014-02-05 12:21 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F22AFB.704@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).