From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 06/11] phy-rcar-usb-gen2: add device tree documentation
Date: Thu, 27 Feb 2014 16:09:38 +0000 [thread overview]
Message-ID: <530F6342.8010703@cogentembedded.com> (raw)
In-Reply-To: <1391595554-20640-7-git-send-email-ben.dooks@codethink.co.uk>
Hello.
On 05-02-2014 14:19, Ben Dooks wrote:
> Documentation for phy-rcar-usb-gen2 device tree binding.
Only phy-rcar-gen2-usb.
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
That's the latest posting of the binding document I've found. It wasn't
posted to linux-usb.
> diff --git a/Documentation/devicetree/bindings/usb/renesas,rcar-gen2-usb-phy.txt b/Documentation/devicetree/bindings/usb/renesas,rcar-gen2-usb-phy.txt
> new file mode 100644
> index 0000000..e1d2dd9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/renesas,rcar-gen2-usb-phy.txt
> @@ -0,0 +1,16 @@
> +Renesas RCar gen2 USB PHY bindings
> +
> +Required properties:
> + - compatible: "renesas,usb-phy-r8a7790" for the R8A7790 SoC or
> + "renesas,rcar-gen2-usb-phy" for any generic comaptible device.
s/comaptible/compatible/. And the second value is seriously not needed.
If you can't test the patch with all SoCs, and are in doubt, just leave one
SoC specific value, and let the others add other values after testing.
> + - reg : A single region to access device registers
> + - clocks : The reference to the clock to use for this block
> + - clock-names : The name for the clock at index 0 (must be "usbhs")
> +
> +Note, interrupt is currently not supported by the driver, but there should
> +be a node in the device tree for it.
Hm, I thought USBHS PHY itself doesn't have any interrupts. Should check
the manuals on whether the USBHS interrupt has any PHY specific conditions...
> +
> +Optional properties:
> +
> + - renesas,usb0-hs: boolean, if present USB0 is connected to HS device.
This description seems completely wrong. The property and bits it control
don't have to do with USB device connected to USB channel 0; they have to do
with the host/function controller, and in this case both alternatives (EHCI
and USBHS) support HS, so the property doesn't provide any real distinction.
> + - renesas,usb2-ss: boolean, if present USB2 is connected to XHCI controller.
It wouldn't hurt to describe what it is connected to USB2 if the property
is missing.
WBR, Sergei
next prev parent reply other threads:[~2014-02-27 16:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 10:19 [PATCH 06/11] phy-rcar-usb-gen2: add device tree documentation Ben Dooks
2014-02-27 16:09 ` Sergei Shtylyov [this message]
2014-02-27 16:28 ` Ben Dooks
2014-02-27 23:11 ` Sergei Shtylyov
2014-02-28 11:17 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530F6342.8010703@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).