From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Fri, 14 Mar 2014 19:06:31 +0000 Subject: Re: [PATCH] sh_eth: ensure pm_runtime cannot suspend the device during init Message-Id: <53236143.4000501@cogentembedded.com> List-Id: References: <1394823605-31883-1-git-send-email-ben.dooks@codethink.co.uk> In-Reply-To: <1394823605-31883-1-git-send-email-ben.dooks@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org Hello. On 03/14/2014 10:01 PM, Ben Dooks wrote: >> It seems the pm_rumtime work queue is causing the device to be suspended >> during initialisation, thus the initialisation may not be able to access >> registers properly. Use pm_runtime_get_sync() and pm_runtime_put_sync() >> to ensure that the pm system does not suspend it during the probe() call. > If this work's for Geert then I'll look into updating the header and > sending it to the netdev list. I keep wondering why I'm seeing no issues in my setup... I don't have drivers/sh/ patch and have CONFIG_PM_RUNTIME=y. Seeing no issues on multiplatform kernels on neither Lager nor Koelsch (however, other platforms are not enabled). WBR, Sergei