From: Ben Dooks <ben.dooks@codethink.co.uk>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH/RFC 0/5] Fix the sh_eth race between open and MDIO bus registration
Date: Wed, 19 Mar 2014 09:14:53 +0000 [thread overview]
Message-ID: <5329600D.9090800@codethink.co.uk> (raw)
In-Reply-To: <1395185156-6681-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On 19/03/14 08:41, Geert Uytterhoeven wrote:
> Hi Laurent,
>
> On Wed, Mar 19, 2014 at 12:25 AM, Laurent Pinchart
> <laurent.pinchart+renesas@ideasonboard.com> wrote:
>> Laurent Pinchart (5):
>> sh_eth: Use the platform device for memory allocation
>> sh_eth: Use the platform device as the MDIO bus parent
>> sh_eth: Simplify MDIO bus initialization and release
>> sh_eth: Register MDIO bus before registering the network device
>> sh_eth: Remove goto statements that jump straight to a return
>
> Thanks, the changes look fine to me, so
I think the only issue I have is the re-parent of the MDIO device.
My view also is that the probe should explicitly get a reference
if it is going to be created sub-devices.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2014-03-19 9:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 23:25 [PATCH/RFC 0/5] Fix the sh_eth race between open and MDIO bus registration Laurent Pinchart
2014-03-19 7:41 ` Geert Uytterhoeven
2014-03-19 9:14 ` Ben Dooks [this message]
2014-03-19 10:07 ` Laurent Pinchart
2014-03-19 13:35 ` Geert Uytterhoeven
2014-03-19 15:06 ` Laurent Pinchart
2014-03-19 15:45 ` Ben Dooks
2014-03-19 15:48 ` Laurent Pinchart
2014-03-19 15:56 ` Ben Dooks
2014-03-19 16:12 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5329600D.9090800@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox