From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Fri, 21 Mar 2014 14:29:45 +0000 Subject: Re: [PATCH v4 6/9] ARM: shmobile: Add PCIe device tree nodes for R8A7790 Message-Id: <532C5ADE.4030708@cogentembedded.com> List-Id: References: <1395397968-6242-1-git-send-email-phil.edworthy@renesas.com> <1395397968-6242-7-git-send-email-phil.edworthy@renesas.com> In-Reply-To: <1395397968-6242-7-git-send-email-phil.edworthy@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Hello. On 03/21/2014 01:32 PM, Phil Edworthy wrote: > This patch adds the device tree nodes for R8A7790 > Signed-off-by: Phil Edworthy > --- > arch/arm/boot/dts/r8a7790.dtsi | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi > index df9ec61..e7d498a 100644 > --- a/arch/arm/boot/dts/r8a7790.dtsi > +++ b/arch/arm/boot/dts/r8a7790.dtsi > @@ -821,4 +821,23 @@ > #size-cells = <0>; > status = "disabled"; > }; > + > + pcie: pcie@fe000000 { > + compatible = "renesas,r8a7790-pcie"; The convention adopted on this list is to put the "pcie" first, and SoC name the last. > + reg = <0 0xfe000000 0 0x80000>; > + #address-cells = <3>; > + #size-cells = <2>; > + device_type = "pci"; This legacy property is only meaningful for the true OF firmware and thus have been phased out (it's only actively used for the memory nodes). WBR, Sergei