From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 2/2] v4l: vsp1: Add missing #include <linux/slab.h>
Date: Mon, 11 Jan 2016 18:27:00 +0000 [thread overview]
Message-ID: <5332920.vEP78QP2FI@avalon> (raw)
In-Reply-To: <1452536727-19538-2-git-send-email-geert+renesas@glider.be>
Hi Geert,
Thank you for the patch.
On Monday 11 January 2016 19:25:27 Geert Uytterhoeven wrote:
> If CONFIG_SPI=n:
>
> drivers/media/platform/vsp1/vsp1_dl.c: In function 'vsp1_dl_create':
> drivers/media/platform/vsp1/vsp1_dl.c:271:2: error: implicit declaration of
> function 'kzalloc' [-Werror=implicit-function-declaration] dl > kzalloc(sizeof(*dl), GFP_KERNEL);
> ^
> drivers/media/platform/vsp1/vsp1_dl.c:271:5: warning: assignment makes
> pointer from integer without a cast dl = kzalloc(sizeof(*dl), GFP_KERNEL);
> ^
> drivers/media/platform/vsp1/vsp1_dl.c:283:3: error: implicit declaration of
> function 'kfree' [-Werror=implicit-function-declaration] kfree(dl);
> ^
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
I have this in my tree already.
> ---
> Against renesas-drivers-2016-01-05-v4.4-rc8
>
> drivers/media/platform/vsp1/vsp1_dl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/vsp1/vsp1_dl.c
> b/drivers/media/platform/vsp1/vsp1_dl.c index
> a4dcccf0778bb479..7dc27ac6bd02a38b 100644
> --- a/drivers/media/platform/vsp1/vsp1_dl.c
> +++ b/drivers/media/platform/vsp1/vsp1_dl.c
> @@ -14,6 +14,7 @@
> #include <linux/device.h>
> #include <linux/dma-mapping.h>
> #include <linux/gfp.h>
> +#include <linux/slab.h>
>
> #include "vsp1.h"
> #include "vsp1_dl.h"
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2016-01-11 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 18:25 [PATCH 2/2] v4l: vsp1: Add missing #include <linux/slab.h> Geert Uytterhoeven
2016-01-11 18:27 ` Laurent Pinchart [this message]
2016-01-11 18:43 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5332920.vEP78QP2FI@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).