From: Ben Dooks <ben.dooks@codethink.co.uk>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 4/5] ARM: shmobile: Call sh_pm_runtime_init() from platform code on all SoCs
Date: Thu, 27 Mar 2014 22:59:07 +0000 [thread overview]
Message-ID: <5334AD3B.9050402@codethink.co.uk> (raw)
In-Reply-To: <1395256010-12222-5-git-send-email-geert@linux-m68k.org>
On 27/03/14 20:05, Geert Uytterhoeven wrote:
> On Wed, Mar 19, 2014 at 8:06 PM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>> Explicitly call sh_pm_runtime_init() from shmobile platform code on all
>> shmobile SoCs, to make sure the bus clocks are enabled for all devices.
>>
>> On ARCH_SHMOBILE_LEGACY, this duplicates the work done in the existing
>> core_initcall() in drivers/sh/pm_runtime.c, which will be removed later.
>> On ARCH_SHMOBILE_MULTI, this was missing, leading to disabled clocks,
>> depending on implicit reset state or on the bootloader.
>>
>> The call to sh_pm_runtime_init() is made from .machine_init(), which is
>> called from an arch_initcall(), i.e. after the old core_initcall().
>
>> diff --git a/arch/arm/mach-shmobile/setup-r8a7791.c b/arch/arm/mach-shmobile/setup-r8a7791.c
>> index a7e4966f5e18..03145c804f50 100644
>> --- a/arch/arm/mach-shmobile/setup-r8a7791.c
>> +++ b/arch/arm/mach-shmobile/setup-r8a7791.c
>> @@ -185,6 +185,7 @@ static const struct resource thermal_resources[] __initconst = {
>>
>> void __init r8a7791_add_dt_devices(void)
>> {
>> + sh_pm_runtime_init();
>
> For koelsch-legacy, this is actually too late: some platform devices
> (pfc, gpio_rcar) have been registered already.
>
IIRC the clock code looks for driver bind/unbind?
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2014-03-27 22:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 19:06 [PATCH 4/5] ARM: shmobile: Call sh_pm_runtime_init() from platform code on all SoCs Geert Uytterhoeven
2014-03-27 20:05 ` Geert Uytterhoeven
2014-03-27 22:59 ` Ben Dooks [this message]
2014-03-28 7:56 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5334AD3B.9050402@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox