* [PATCH 9/9] ARM: shmobile: lager.dts: link usb-phy to pci nodes
@ 2014-03-06 18:01 Ben Dooks
2014-03-30 19:29 ` Sergei Shtylyov
2014-03-30 19:47 ` Ben Dooks
0 siblings, 2 replies; 3+ messages in thread
From: Ben Dooks @ 2014-03-06 18:01 UTC (permalink / raw)
To: linux-sh
Add the necessary links to add the USB phy nodes to the PCI devices
that are behind the bridges specified.
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
arch/arm/boot/dts/r8a7790-lager.dts | 37 +++++++++++++++++++++++++++++++++++++
1 file changed, 37 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
index 63d58d6..62f486e 100644
--- a/arch/arm/boot/dts/r8a7790-lager.dts
+++ b/arch/arm/boot/dts/r8a7790-lager.dts
@@ -233,18 +233,55 @@
&pci0 {
pinctrl-0 = <&usb0_pins>;
pinctrl-names = "default";
+ device_type = "pci";
+
+ pci@0,1 {
+ reg = <0x800 0 0 0 0>;
+ device_type = "pci";
+ usb-phy = <&usbphy>;
+ };
+
+ pci@0,2 {
+ reg = <0x1000 0 0 0 0>;
+ device_type = "pci";
+ usb-phy = <&usbphy>;
+ };
};
&pci1 {
status = "okay";
pinctrl-0 = <&usb1_pins>;
pinctrl-names = "default";
+
+ pci@0,1 {
+ reg = <0x800 0 0 0 0>;
+ device_type = "pci";
+ usb-phy = <&usbphy>;
+ };
+
+ pci@0,2 {
+ reg = <0x1000 0 0 0 0>;
+ device_type = "pci";
+ usb-phy = <&usbphy>;
+ };
};
&pci2 {
status = "okay";
pinctrl-0 = <&usb2_pins>;
pinctrl-names = "default";
+
+ pci@0,1 {
+ reg = <0x800 0 0 0 0>;
+ device_type = "pci";
+ usb-phy = <&usbphy>;
+ };
+
+ pci@0,2 {
+ reg = <0x1000 0 0 0 0>;
+ device_type = "pci";
+ usb-phy = <&usbphy>;
+ };
};
&usbphy {
--
1.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 9/9] ARM: shmobile: lager.dts: link usb-phy to pci nodes
2014-03-06 18:01 [PATCH 9/9] ARM: shmobile: lager.dts: link usb-phy to pci nodes Ben Dooks
@ 2014-03-30 19:29 ` Sergei Shtylyov
2014-03-30 19:47 ` Ben Dooks
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2014-03-30 19:29 UTC (permalink / raw)
To: linux-sh
Hello.
On 03/06/2014 09:01 PM, Ben Dooks wrote:
> Add the necessary links to add the USB phy nodes to the PCI devices
> that are behind the bridges specified.
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> arch/arm/boot/dts/r8a7790-lager.dts | 37 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 37 insertions(+)
> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> index 63d58d6..62f486e 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> @@ -233,18 +233,55 @@
> &pci0 {
> pinctrl-0 = <&usb0_pins>;
> pinctrl-names = "default";
> + device_type = "pci";
> +
> + pci@0,1 {
> + reg = <0x800 0 0 0 0>;
> + device_type = "pci";
> + usb-phy = <&usbphy>;
> + };
> +
> + pci@0,2 {
> + reg = <0x1000 0 0 0 0>;
> + device_type = "pci";
> + usb-phy = <&usbphy>;
> + };
> };
>
> &pci1 {
> status = "okay";
> pinctrl-0 = <&usb1_pins>;
> pinctrl-names = "default";
> +
> + pci@0,1 {
> + reg = <0x800 0 0 0 0>;
> + device_type = "pci";
> + usb-phy = <&usbphy>;
> + };
> +
> + pci@0,2 {
> + reg = <0x1000 0 0 0 0>;
> + device_type = "pci";
> + usb-phy = <&usbphy>;
> + };
> };
>
> &pci2 {
> status = "okay";
> pinctrl-0 = <&usb2_pins>;
> pinctrl-names = "default";
> +
> + pci@0,1 {
> + reg = <0x800 0 0 0 0>;
> + device_type = "pci";
> + usb-phy = <&usbphy>;
> + };
> +
> + pci@0,2 {
> + reg = <0x1000 0 0 0 0>;
> + device_type = "pci";
> + usb-phy = <&usbphy>;
> + };
> };
I don't see why the internal PCI devices are added to the board file, not
the SoC file.
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 9/9] ARM: shmobile: lager.dts: link usb-phy to pci nodes
2014-03-06 18:01 [PATCH 9/9] ARM: shmobile: lager.dts: link usb-phy to pci nodes Ben Dooks
2014-03-30 19:29 ` Sergei Shtylyov
@ 2014-03-30 19:47 ` Ben Dooks
1 sibling, 0 replies; 3+ messages in thread
From: Ben Dooks @ 2014-03-30 19:47 UTC (permalink / raw)
To: linux-sh
On 30/03/14 20:29, Sergei Shtylyov wrote:
> Hello.
>
> On 03/06/2014 09:01 PM, Ben Dooks wrote:
>
>> Add the necessary links to add the USB phy nodes to the PCI devices
>> that are behind the bridges specified.
>
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>> ---
>> arch/arm/boot/dts/r8a7790-lager.dts | 37
>> +++++++++++++++++++++++++++++++++++++
>> 1 file changed, 37 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts
>> b/arch/arm/boot/dts/r8a7790-lager.dts
>> index 63d58d6..62f486e 100644
>> --- a/arch/arm/boot/dts/r8a7790-lager.dts
>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
>> @@ -233,18 +233,55 @@
>> &pci0 {
>> pinctrl-0 = <&usb0_pins>;
>> pinctrl-names = "default";
>> + device_type = "pci";
>> +
>> + pci@0,1 {
>> + reg = <0x800 0 0 0 0>;
>> + device_type = "pci";
>> + usb-phy = <&usbphy>;
>> + };
>> +
>> + pci@0,2 {
>> + reg = <0x1000 0 0 0 0>;
>> + device_type = "pci";
>> + usb-phy = <&usbphy>;
>> + };
>> };
>>
>> &pci1 {
>> status = "okay";
>> pinctrl-0 = <&usb1_pins>;
>> pinctrl-names = "default";
>> +
>> + pci@0,1 {
>> + reg = <0x800 0 0 0 0>;
>> + device_type = "pci";
>> + usb-phy = <&usbphy>;
>> + };
>> +
>> + pci@0,2 {
>> + reg = <0x1000 0 0 0 0>;
>> + device_type = "pci";
>> + usb-phy = <&usbphy>;
>> + };
>> };
>>
>> &pci2 {
>> status = "okay";
>> pinctrl-0 = <&usb2_pins>;
>> pinctrl-names = "default";
>> +
>> + pci@0,1 {
>> + reg = <0x800 0 0 0 0>;
>> + device_type = "pci";
>> + usb-phy = <&usbphy>;
>> + };
>> +
>> + pci@0,2 {
>> + reg = <0x1000 0 0 0 0>;
>> + device_type = "pci";
>> + usb-phy = <&usbphy>;
>> + };
>> };
>
> I don't see why the internal PCI devices are added to the board
> file, not the SoC file.
Thanks, I think they probably do belong in the .dtsi file.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-30 19:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-06 18:01 [PATCH 9/9] ARM: shmobile: lager.dts: link usb-phy to pci nodes Ben Dooks
2014-03-30 19:29 ` Sergei Shtylyov
2014-03-30 19:47 ` Ben Dooks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).