From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: r8a7790: link PCI USb devices to USB PHY
Date: Thu, 10 Apr 2014 10:38:45 +0000 [thread overview]
Message-ID: <534674B5.6080706@cogentembedded.com> (raw)
In-Reply-To: <CANqRtoQeuT=Q9PRYNMqA079gjb1VkwgvcDmsWKxjzSVxcVfeWw@mail.gmail.com>
Hello.
On 10-04-2014 11:07, Magnus Damm wrote:
> Thanks for this patch, good to see that the relationship between the
> USB Host and the PHY is described via DT.
> This patch seems to cover USB0 and USB2 that both require special
> control in the PHY. How about USB1? Can you explain about the reason
> why you omit that?
Because the driver does nothing for USB1 anyway.
> I somehow expected USB1 to be tied to the PHY via DT as well, this so
> the PHY driver can be able to disable the hardware if no ports are
> registered. In detail, I'm thinking that the register.bit
> UGCTL.CONNECT wants to be set to 0 by default but be set to 1 once one
> or more USB controllers are hooked up to the PHY.
I don't think this bit has any sense for non-USBHS controllers. EHCI/OHCI
drivers happily work without setting it.
WBR, Sergei
next prev parent reply other threads:[~2014-04-10 10:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 19:18 [PATCH] ARM: shmobile: r8a7790: link PCI USb devices to USB PHY Sergei Shtylyov
2014-04-10 7:07 ` Magnus Damm
2014-04-10 10:38 ` Sergei Shtylyov [this message]
2014-04-10 18:46 ` Sergei Shtylyov
2014-04-11 5:48 ` Magnus Damm
2014-04-11 11:39 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534674B5.6080706@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).