From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v3 2/7] adv7180: add of match table
Date: Tue, 15 Apr 2014 11:24:12 +0000 [thread overview]
Message-ID: <534D16DC.5010808@cogentembedded.com> (raw)
In-Reply-To: <1397471802-27216-3-git-send-email-ben.dooks@codethink.co.uk>
Hello.
On 14-04-2014 14:36, Ben Dooks wrote:
> Add a proper of match id for use when the device is being bound via
> device tree, to avoid having to use the i2c old-style binding of the
> device.
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> drivers/media/i2c/adv7180.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
> diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c
> index 215afa0..687d97b 100644
> --- a/drivers/media/i2c/adv7180.c
> +++ b/drivers/media/i2c/adv7180.c
[...]
> @@ -695,11 +696,21 @@ static SIMPLE_DEV_PM_OPS(adv7180_pm_ops, adv7180_suspend, adv7180_resume);
>
> MODULE_DEVICE_TABLE(i2c, adv7180_id);
>
> +#ifdef CONFIG_OF
Don't think it's worth using #ifdef.
> +static const struct of_device_id adv7180_of_id[] = {
> + { .compatible = "adi,adv7180", },
> + { },
> +};
> +
> +MODULE_DEVICE_TABLE(of, adv7180_of_id)
> +#endif
WBR, Sergei
next prev parent reply other threads:[~2014-04-15 11:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 10:36 [PATCH v3 2/7] adv7180: add of match table Ben Dooks
2014-04-15 11:24 ` Sergei Shtylyov [this message]
2014-05-08 23:23 ` Sergei Shtylyov
2014-05-08 23:47 ` Sergei Shtylyov
2014-05-09 7:01 ` Geert Uytterhoeven
2014-05-09 22:57 ` Sergei Shtylyov
2014-06-05 23:03 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534D16DC.5010808@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).