linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 02/02] ARM: shmobile: Add SDHI devices for Koelsch DTS
Date: Sat, 03 May 2014 00:11:08 +0000	[thread overview]
Message-ID: <5364341C.9030105@cogentembedded.com> (raw)
In-Reply-To: <20140212095404.4832.61203.sendpatchset@w520>

Hello.

On 02/12/2014 12:54 PM, Magnus Damm wrote:

> From: Magnus Damm <damm@opensource.se>

> Add DT support for SDHI0, SDHI1 and SDHI2 on Koelsch.

> The board specific handling of CD and WP pins are
> using GPIOs.

    Frankly speaking, I didn't understand why. The native SDHI[012] CD/WP pins 
are used in the legacy Koelsch code, why not do the same in the device tree?

> SDHI0 and SDHI1 are hooked up to regular
> SD connectors while SDHI2 is using micro-SD which
> is lacking WP signal.

> Signed-off-by: Magnus Damm <damm@opensource.se>

PS: I've done some limited testing of the SDHI using the dedicated CD/WP pins 
on both Koelsch and Henninger boards; I haven't tested card insertion/removal 
since I only have remote access to the boards and it's holiday in Russia 
anyway. :-)

WBR, Sergei


  reply	other threads:[~2014-05-03  0:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-12  9:54 [PATCH v2 02/02] ARM: shmobile: Add SDHI devices for Koelsch DTS Magnus Damm
2014-05-03  0:11 ` Sergei Shtylyov [this message]
2014-05-03 15:51 ` Sergei Shtylyov
2014-05-03 19:16 ` Magnus Damm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5364341C.9030105@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).