* [PATCH v3 4/7] ARM: lager: add vin1 node
@ 2014-04-14 10:36 Ben Dooks
2014-05-03 16:56 ` Guennadi Liakhovetski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Ben Dooks @ 2014-04-14 10:36 UTC (permalink / raw)
To: linux-sh
Add device-tree for vin1 (composite video in) on the
lager board.
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
arch/arm/boot/dts/r8a7790-lager.dts | 38 +++++++++++++++++++++++++++++++++++++
1 file changed, 38 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
index a087421..6888866 100644
--- a/arch/arm/boot/dts/r8a7790-lager.dts
+++ b/arch/arm/boot/dts/r8a7790-lager.dts
@@ -158,6 +158,11 @@
renesas,groups = "i2c2";
renesas,function = "i2c2";
};
+
+ vin1_pins: vin {
+ renesas,groups = "vin1_data8", "vin1_clk";
+ renesas,function = "vin1";
+ };
};
&mmcif1 {
@@ -239,8 +244,41 @@
status = "ok";
pinctrl-0 = <&i2c2_pins>;
pinctrl-names = "default";
+
+ adv7180: composite-in@0x20 {
+ compatible = "adi,adv7180";
+ reg = <0x20>;
+ remote = <&vin1>;
+
+ port {
+ adv7180_1: endpoint {
+ bus-width = <8>;
+ remote-endpoint = <&vin1ep0>;
+ };
+ };
+ };
+
};
&i2c3 {
status = "ok";
};
+
+/* composite video input */
+&vin1 {
+ pinctrl-0 = <&vin1_pins>;
+ pinctrl-names = "default";
+
+ status = "ok";
+
+ port {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ vin1ep0: endpoint {
+ remote-endpoint = <&adv7180_1>;
+ bus-width = <8>;
+ };
+ };
+};
+
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v3 4/7] ARM: lager: add vin1 node
2014-04-14 10:36 [PATCH v3 4/7] ARM: lager: add vin1 node Ben Dooks
@ 2014-05-03 16:56 ` Guennadi Liakhovetski
2014-05-08 23:37 ` Sergei Shtylyov
2014-06-06 20:57 ` Sergei Shtylyov
2 siblings, 0 replies; 4+ messages in thread
From: Guennadi Liakhovetski @ 2014-05-03 16:56 UTC (permalink / raw)
To: linux-sh
On Mon, 14 Apr 2014, Ben Dooks wrote:
> Add device-tree for vin1 (composite video in) on the
> lager board.
I think this patch should be the last. The rest isn't so important, but
also for them I would go from more generic to device / platform / board
specific ones.
Thanks
Guennadi
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> arch/arm/boot/dts/r8a7790-lager.dts | 38 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> index a087421..6888866 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> @@ -158,6 +158,11 @@
> renesas,groups = "i2c2";
> renesas,function = "i2c2";
> };
> +
> + vin1_pins: vin {
> + renesas,groups = "vin1_data8", "vin1_clk";
> + renesas,function = "vin1";
> + };
> };
>
> &mmcif1 {
> @@ -239,8 +244,41 @@
> status = "ok";
> pinctrl-0 = <&i2c2_pins>;
> pinctrl-names = "default";
> +
> + adv7180: composite-in@0x20 {
> + compatible = "adi,adv7180";
> + reg = <0x20>;
> + remote = <&vin1>;
> +
> + port {
> + adv7180_1: endpoint {
> + bus-width = <8>;
> + remote-endpoint = <&vin1ep0>;
> + };
> + };
> + };
> +
> };
>
> &i2c3 {
> status = "ok";
> };
> +
> +/* composite video input */
> +&vin1 {
> + pinctrl-0 = <&vin1_pins>;
> + pinctrl-names = "default";
> +
> + status = "ok";
> +
> + port {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + vin1ep0: endpoint {
> + remote-endpoint = <&adv7180_1>;
> + bus-width = <8>;
> + };
> + };
> +};
> +
> --
> 1.9.1
>
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v3 4/7] ARM: lager: add vin1 node
2014-04-14 10:36 [PATCH v3 4/7] ARM: lager: add vin1 node Ben Dooks
2014-05-03 16:56 ` Guennadi Liakhovetski
@ 2014-05-08 23:37 ` Sergei Shtylyov
2014-06-06 20:57 ` Sergei Shtylyov
2 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2014-05-08 23:37 UTC (permalink / raw)
To: linux-sh
Hello.
On 04/14/2014 02:36 PM, Ben Dooks wrote:
> Add device-tree for vin1 (composite video in) on the
> lager board.
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> arch/arm/boot/dts/r8a7790-lager.dts | 38 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> index a087421..6888866 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
[...]
> @@ -239,8 +244,41 @@
> status = "ok";
> pinctrl-0 = <&i2c2_pins>;
> pinctrl-names = "default";
> +
> + adv7180: composite-in@0x20 {
You're not using that label, as far as I could see.
> + compatible = "adi,adv7180";
> + reg = <0x20>;
> + remote = <&vin1>;
> +
> + port {
> + adv7180_1: endpoint {
So, you could use 'adv7180:' here instead...
> + bus-width = <8>;
> + remote-endpoint = <&vin1ep0>;
> + };
> + };
> + };
> +
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v3 4/7] ARM: lager: add vin1 node
2014-04-14 10:36 [PATCH v3 4/7] ARM: lager: add vin1 node Ben Dooks
2014-05-03 16:56 ` Guennadi Liakhovetski
2014-05-08 23:37 ` Sergei Shtylyov
@ 2014-06-06 20:57 ` Sergei Shtylyov
2 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2014-06-06 20:57 UTC (permalink / raw)
To: linux-sh
Hello.
On 04/14/2014 02:36 PM, Ben Dooks wrote:
> Add device-tree for vin1 (composite video in) on the
> lager board.
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> arch/arm/boot/dts/r8a7790-lager.dts | 38 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> index a087421..6888866 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
[...]
> @@ -239,8 +244,41 @@
> status = "ok";
> pinctrl-0 = <&i2c2_pins>;
> pinctrl-names = "default";
> +
> + adv7180: composite-in@0x20 {
Please drop "0x" from the unit-addresspart of the node name.
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-06-06 20:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-14 10:36 [PATCH v3 4/7] ARM: lager: add vin1 node Ben Dooks
2014-05-03 16:56 ` Guennadi Liakhovetski
2014-05-08 23:37 ` Sergei Shtylyov
2014-06-06 20:57 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).