From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yoshihiro Shimoda Date: Tue, 20 May 2014 09:34:52 +0000 Subject: Re: [PATCH 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers Message-Id: <537B21BC.7040701@renesas.com> List-Id: References: <5379D805.3070002@renesas.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Magnus Damm Cc: "mathias.nyman-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" , Greg Kroah-Hartman , "linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , SH-Linux , Geert Uytterhoeven , Grant Likely , Rob Herring , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" Hi Magnus-san, (2014/05/19 19:21), Magnus Damm wrote: > Hi Shimoda-san, > > Thanks for your patches, I did however find one typo below: > > On Mon, May 19, 2014 at 7:08 PM, Yoshihiro Shimoda > wrote: < snip > >> static int xhci_plat_start(struct usb_hcd *hcd) >> { >> + struct device_node *of_node = hcd->self.controller->of_node; >> + >> + if (of_device_is_compatible(of_node, "renesas,r8a7790-xhci") || >> + of_device_is_compatible(of_node, "renesas,r8a7790-xhci")) >> + xhci_rcar_start(hcd); >> + > > This is most likely a typo - I believe this is supposed to be r8a7790 > and r8a7791? Thank you for the review! Yes, this is a typo... I will correct this. Best regards, Yoshihiro Shimoda > Cheers, > > / magnus > -- Yoshihiro Shimoda EC No.