From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Tue, 27 May 2014 19:38:36 +0000 Subject: Re: [PATCH v4] phy: Renesas R-Car Gen2 PHY driver Message-Id: <5384E9BC.8090202@cogentembedded.com> List-Id: References: <201405240206.04700.sergei.shtylyov@cogentembedded.com> <53845B05.80900@renesas.com> In-Reply-To: <53845B05.80900@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yoshihiro Shimoda , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "kishon@ti.com" , "grant.likely@linaro.org" , "devicetree@vger.kernel.org" Cc: "rdunlap@infradead.org" , "linux-doc@vger.kernel.org" , "linux-sh@vger.kernel.org" Hello. On 05/27/2014 01:29 PM, Yoshihiro Shimoda wrote: >> +Example (Lager board): >> + >> + usb-phy@e6590100 { >> + compatible = "renesas,usb-phy-r8a7790"; >> + reg = <0 0xe6590100 0 0x100>; >> + #phy-cells = <2>; >> + clocks = <&mstp7_clks R8A7790_CLK_HSUSB>; >> + clock-names = "usbhs"; > I'm not sure about the clock-names string, > but the current clock-name of R8A7790_CLK_HSUSB I guess you meant "clock-output-names" prop? > is "hsusb" in r8a7790.dtsi. Yes. But it doesn't have to match to what's passed to devm_clk_get(). > So, before I tested this driver, I changed the "hsusb" to "usbhs". > Otherwise, the devm_clk_get() in the driver failed. This is very strange, the driver works OK for me. > < snip > >> + for_each_child_of_node(dev->of_node, np) { >> + struct rcar_gen2_phy *phy; > > This line has two while spaces at the start of the line. Thank you, looks like I cut&pasted from a bad source and forgot to run the patch thru scripts/checkpatch.pl... > Best regards, > Yoshihiro Shimoda WBR, Sergei