From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Dooks Date: Mon, 02 Jun 2014 13:53:01 +0000 Subject: Re: [PATCH v2 7/7] ARM: shmobile: r8a7791 dtsi: Enable DMA for QSPI Message-Id: <538C81BD.5090502@codethink.co.uk> List-Id: References: <1401716531-29794-1-git-send-email-geert+renesas@glider.be> <1401716531-29794-8-git-send-email-geert+renesas@glider.be> In-Reply-To: <1401716531-29794-8-git-send-email-geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On 02/06/14 14:42, Geert Uytterhoeven wrote: > Add a DMA property to the QSPI node > > Signed-off-by: Geert Uytterhoeven > --- > v2: > - QSPI needs to use 8-bit accesses for DMA, not 32-bit, > - Reorder: TX first, RX second. > > arch/arm/boot/dts/r8a7791.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi > index 37685ef32ea0..6c285ffc46cb 100644 > --- a/arch/arm/boot/dts/r8a7791.dtsi > +++ b/arch/arm/boot/dts/r8a7791.dtsi > @@ -917,6 +917,9 @@ > reg = <0 0xe6b10000 0 0x2c>; > interrupts = <0 184 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&mstp9_clks R8A7791_CLK_QSPI_MOD>; > + dmas = <&dma0 R8A7791_DMA_QSPI_TX CHCR_TX_8BIT>, > + <&dma0 R8A7791_DMA_QSPI_RX CHCR_RX_8BIT>; > + dma-names = "tx", "rx"; I am hopeful that we can remove the CHCR settings, each driver should configure the width when configuring the slave. V2 of the patches will reflect this. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius