From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Dooks Date: Wed, 04 Jun 2014 16:04:45 +0000 Subject: Re: [PATCH v2 3/9] ARM: shmobile: r8a7790: add dmac0 dmac1 nodes Message-Id: <538F439D.1000001@codethink.co.uk> List-Id: References: <1397511312-4845-1-git-send-email-ben.dooks@codethink.co.uk> <1397511312-4845-4-git-send-email-ben.dooks@codethink.co.uk> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Geert Uytterhoeven Cc: linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO@public.gmane.org, dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Vinod Koul , Dan Williams , Linux-sh list , magnus.damm-yzvPICuk2ACczHhG9Qg4qA@public.gmane.org, Simon Horman , Guennadi Liakhovetski , Kuninori Morimoto , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" On 13/05/14 13:00, Geert Uytterhoeven wrote: > Hi Ben, > > On Mon, Apr 14, 2014 at 11:35 PM, Ben Dooks wrote: >> --- a/arch/arm/boot/dts/r8a7790.dtsi >> +++ b/arch/arm/boot/dts/r8a7790.dtsi >> @@ -86,6 +88,76 @@ >> }; >> }; >> >> + dma0: dma-mux@0 { >> + compatible = "renesas,shdma-mux"; >> + #dma-cells = <2>; >> + dma-channels = <20>; > > Shouldn't this be 30, i.e. the sum of the properties in the child nodes? Thanks, fixed. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius