From: Ben Dooks <ben.dooks@codethink.co.uk>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 5/8] shdmac: fdt: wire r8a7790 for device tree usage.
Date: Thu, 05 Jun 2014 09:57:29 +0000 [thread overview]
Message-ID: <53903F09.7020001@codethink.co.uk> (raw)
In-Reply-To: <1401898455-31064-6-git-send-email-ben.dooks@codethink.co.uk>
On 05/06/14 09:16, Kuninori Morimoto wrote:
>
> Hi Ben
>
>> Add support for R8A7790 with new device tree code
>>
>> Note, not yet converted the only other user to dt yet
>>
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>> ---
> (snip)
>> static const struct of_device_id sh_dmae_of_match[] = {
>> - {.compatible = "renesas,shdma-r8a73a4", .data = r8a73a4_shdma_devid,},
>> + { .compatible = "renesas,shdma-r8a73a4", .data = r8a73a4_shdma_devid },
>> + { .compatible = "renesas,dma-r8a7790", .data = &shdma_arm_info },
>> {}
>> };
>
> renesas,shdma-r8a7790 ?
> renesas,dma-r8a7790 ?
>
> Is this typo ? or on purpose ?
Thanks for the feedback.
I thought dma was a pretty good description. Do we need to call this
shdma-r8a7790?
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2014-06-05 9:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 16:14 [PATCH 5/8] shdmac: fdt: wire r8a7790 for device tree usage Ben Dooks
2014-06-05 8:16 ` Kuninori Morimoto
2014-06-05 9:57 ` Ben Dooks [this message]
2014-06-05 10:09 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53903F09.7020001@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).