From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Mon, 16 Jun 2014 12:13:38 +0000 Subject: Re: [PATCH] ARM: shmobile: rcar-gen2: correct return value of shmobile_smp_apmu_suspend_init Message-Id: <539EDF72.7080305@cogentembedded.com> List-Id: References: <1402918044-29961-1-git-send-email-horms+renesas@verge.net.au> In-Reply-To: <1402918044-29961-1-git-send-email-horms+renesas@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Hello. On 06/16/2014 03:27 PM, Simon Horman wrote: > The dummy shmobile_smp_apmu_suspend_init() function provided when > CPU_IDLE is not set should not return a value as per the signature > of the function. > This problem appears to have been introduced by > 867ba81f728f1daa ("ARM: shmobile: APMU: Add Core-Standby-state for Suspend > to RAM"). > Cc: Keita Kobayashi > Signed-off-by: Simon Horman [...] > diff --git a/arch/arm/mach-shmobile/include/mach/common.h b/arch/arm/mach-shmobile/include/mach/common.h > index 8f0cd57..46766fc 100644 > --- a/arch/arm/mach-shmobile/include/mach/common.h > +++ b/arch/arm/mach-shmobile/include/mach/common.h > @@ -38,7 +38,7 @@ int shmobile_suspend_init(void); > void shmobile_smp_apmu_suspend_init(void); > #else > static inline int shmobile_suspend_init(void) { return 0; } > -static inline void shmobile_smp_apmu_suspend_init(void) { return 0; } > +static inline void shmobile_smp_apmu_suspend_init(void) { return; } I wonder why you kept *return* at all? WBR, Sergei