From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
alsa-devel@alsa-project.org
Cc: linux-sh@vger.kernel.org,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH] ASoC: rsnd: Protect register accesses with a spinlock instead of a mutex
Date: Sun, 27 Jul 2014 10:36:47 +0000 [thread overview]
Message-ID: <53D4D63F.6010701@codethink.co.uk> (raw)
In-Reply-To: <1406150366-10169-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On 23/07/14 22:19, Laurent Pinchart wrote:
> The hardware registers are accessed from atomic contexts (the
> rsnd_soc_dai_trigger function, for instance, is called with the PCM
> substream spinlock held). They thus can't be protected by a mutex.
>
> Protect regmap register accesses with a spinlock instead of a mutex by
> setting the fast_io flag.
I reported this ages ago.
I ended up removing regmap entirely, it just locks the machine
solid and provides no useful functionality for the driver.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
prev parent reply other threads:[~2014-07-27 10:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 21:19 [PATCH] ASoC: rsnd: Protect register accesses with a spinlock instead of a mutex Laurent Pinchart
2014-07-24 0:15 ` [alsa-devel] " Kuninori Morimoto
2014-07-24 2:16 ` Kuninori Morimoto
2014-07-28 5:59 ` Lars-Peter Clausen
2014-07-28 7:40 ` Kuninori Morimoto
2014-07-28 8:03 ` Lars-Peter Clausen
2014-07-28 8:33 ` Kuninori Morimoto
2014-07-27 10:36 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D4D63F.6010701@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox