From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2] sh-pfc: r8a7791: add CAN pin groups
Date: Mon, 28 Jul 2014 20:19:37 +0000 [thread overview]
Message-ID: <53D6B059.6050300@cogentembedded.com> (raw)
In-Reply-To: <201407020058.17369.sergei.shtylyov@cogentembedded.com>
Hello.
On 07/02/2014 12:58 AM, Sergei Shtylyov wrote:
> Add CAN0/1 data/clock pin groups to R8A7791 PFC driver.
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> ---
> The patch is against the 'devel' branch of Linus W.'s 'linux-pinctrl.git' repo.
> Changes in version 2:
> - fixed CAN_CLK_C pin mapping;
> - renamed can[01]_{clk|data}_a_*[] to can[01]_{clk|data}_*[];
As it turned out, this rename wasn't enough...
> - added pin name comments to can*_pins[] initializers.
> drivers/pinctrl/sh-pfc/pfc-r8a7791.c | 167 +++++++++++++++++++++++++++++++++++
> 1 file changed, 167 insertions(+)
> Index: linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> =================================> --- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> +++ linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
[...]
> @@ -4367,6 +4508,30 @@ static const char * const audio_clk_grou
> "audio_clkout",
> };
>
> +static const char * const can0_groups[] = {
> + "can0_data_a",
Crap, forgot to fix this to "can0_data"... :-(
> + "can0_data_b",
> + "can0_data_c",
> + "can0_data_d",
> + "can0_data_e",
> + "can0_data_f",
> + "can_clk_a",
> + "can_clk_b",
> + "can_clk_c",
> + "can_clk_d",
> +};
> +
> +static const char * const can1_groups[] = {
> + "can1_data_a",
And this one too... :-(
> + "can1_data_b",
> + "can1_data_c",
> + "can1_data_d",
> + "can_clk_a",
> + "can_clk_b",
> + "can_clk_c",
> + "can_clk_d",
> +};
> +
Now that the patch is merged, I assume I'll have to send a fix...
WBR, Sergei
prev parent reply other threads:[~2014-07-28 20:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 20:58 [PATCH v2] sh-pfc: r8a7791: add CAN pin groups Sergei Shtylyov
2014-07-01 21:05 ` Laurent Pinchart
2014-07-08 8:43 ` Linus Walleij
2014-07-28 20:19 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D6B059.6050300@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).