From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Fri, 01 Aug 2014 22:16:29 +0000 Subject: Re: [PATCH 3/4] media: rcar_vin: Fix race condition terminating stream Message-Id: <53DC11BD.6060409@cogentembedded.com> List-Id: References: <1404812474-7627-1-git-send-email-ian.molton@codethink.co.uk> <1404812474-7627-4-git-send-email-ian.molton@codethink.co.uk> <53BC17D6.2070607@cogentembedded.com> <20140710111523.17ae9078e53001c18bdf6eac@codethink.co.uk> In-Reply-To: <20140710111523.17ae9078e53001c18bdf6eac@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ian Molton Cc: linux-media@vger.kernel.org, linux-kernel@lists.codethink.co.uk, g.liakhovetski@gmx.de, m.chehab@samsung.com, vladimir.barinov@cogentembedded.com, magnus.damm@gmail.com, horms@verge.net.au, linux-sh@vger.kernel.org Hello. On 07/10/2014 02:15 PM, Ian Molton wrote: >>> Signed-off-by: Ian Molton >>> Signed-off-by: William Towle >>> --- >>> drivers/media/platform/soc_camera/rcar_vin.c | 43 ++++++++++++++++++---------- >>> 1 file changed, 28 insertions(+), 15 deletions(-) >>> diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c >>> index 06ce705..aeda4e2 100644 >>> --- a/drivers/media/platform/soc_camera/rcar_vin.c >>> +++ b/drivers/media/platform/soc_camera/rcar_vin.c >> [...] >>> @@ -462,7 +485,6 @@ static void rcar_vin_videobuf_release(struct vb2_buffer *vb) >>> struct rcar_vin_priv *priv = ici->priv; >>> unsigned int i; >>> int buf_in_use = 0; >>> - >>> spin_lock_irq(&priv->lock); >> This seems like a random whitespace change. This empty should be present. > Agreed. >> [...] >>> @@ -517,12 +527,15 @@ static void rcar_vin_stop_streaming(struct vb2_queue *vq) >>> >>> spin_lock_irq(&priv->lock); >>> >>> + rcar_vin_wait_stop_streaming(priv); >>> + >>> for (i = 0; i < vq->num_buffers; ++i) >>> if (vq->bufs[i]->state = VB2_BUF_STATE_ACTIVE) >>> vb2_buffer_done(vq->bufs[i], VB2_BUF_STATE_ERROR); >>> >>> list_for_each_safe(buf_head, tmp, &priv->capture) >>> list_del_init(buf_head); >>> + >> >> Also quite a random "drove-by" change. > Agreed. > Any further comments? If not, I can re-spin this ready for upstreaming. There has been no further comments but you've never re-appeared. :-( Now I'm about to test these patches... WBR, Sergei