From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
SH-Linux <linux-sh@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 1/2] usb: renesas_usbhs: Add device tree bindings documentation
Date: Mon, 04 Aug 2014 04:24:54 +0000 [thread overview]
Message-ID: <53DF0B16.4040405@renesas.com> (raw)
In-Reply-To: <53DB97B7.2090203@cogentembedded.com>
Hello,
(2014/08/01 22:35), Sergei Shtylyov wrote:
> Hello.
>
> On 08/01/2014 03:49 PM, Yoshihiro Shimoda wrote:
>
>> Document the device tree bindings for the Renesas USBHS controller.
>
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> ---
>> .../devicetree/bindings/usb/renesas_usbhs.txt | 24 ++++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/usb/renesas_usbhs.txt
>
>> diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
>> new file mode 100644
>> index 0000000..e9faa65
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
>> @@ -0,0 +1,24 @@
>> +Renesas Electronics USBHS driver
>> +
>> +Required properties:
>> + - compatible: Must contain one of the following:
>> + - "renesas,usbhs-r8a7790"
>> + - "renesas,usbhs-r8a7791"
>> + - reg: Base address and length of the register for the USBHS
>> + - interrupts: Interrupt specifier for the USBHS
>> + - clocks: A list of phandle + clock specifier pairs
>> +
>> +Optional properties:
>> + - buswait_bwait: Integer to use BUSWAIT register
>
> Should be named "renesas,buswait-bwait" or probably just "renesas,buswait".
Thank you for the point. I will fix this name to "renesas,buswait".
>> + - enable-gpio: A gpio specifier to check GPIO determining if USB function
>
> Should also be prefixed with "renesas,".
I will fix this name to "renesas,enable-gpio".
Best regards,
Yoshihiro Shimoda
> [...]
>
> WBR, Sergei
>
prev parent reply other threads:[~2014-08-04 4:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 11:49 [PATCH 1/2] usb: renesas_usbhs: Add device tree bindings documentation Yoshihiro Shimoda
[not found] ` <53DB7EBA.3080004-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2014-08-01 13:35 ` Sergei Shtylyov
2014-08-04 4:24 ` Yoshihiro Shimoda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DF0B16.4040405@renesas.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).