From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Ian Molton <ian.molton@codethink.co.uk>, linux-media@vger.kernel.org
Cc: linux-kernel@lists.codethink.co.uk, g.liakhovetski@gmx.de,
m.chehab@samsung.com, vladimir.barinov@cogentembedded.com,
magnus.damm@gmail.com, horms@verge.net.au,
linux-sh@vger.kernel.org
Subject: Re: Resend: [PATCH 0/4] rcar_vin: fix soc_camera WARN_ON() issues.
Date: Mon, 04 Aug 2014 20:00:20 +0000 [thread overview]
Message-ID: <53DFE654.1000102@cogentembedded.com> (raw)
In-Reply-To: <1404812474-7627-1-git-send-email-ian.molton@codethink.co.uk>
Hello.
On 07/08/2014 01:41 PM, Ian Molton wrote:
> Resent to include the author and a couple of other interested parties :)
Thank you (despite you didn't include me :-).
> This patch series provides fixes that allow the rcar_vin driver to function
> without triggering dozens of warnings from the videobuf2 and soc_camera layers.
> Patches 2/3 should probably be merged into a single, atomic change, although
> patch 2 does not make the existing situation /worse/ in and of itself.
Perhaps it's worth to just swap patches 2 & 3...
> Patch 4 does not change the code logic, but is cleaner and less prone to
> breakage caused by furtutre modification. Also, more consistent with the use of
> vb pointers elsewhere in the driver.
It's not a good practice to post fixes and clean-ups in a single series.
> Comments welcome!
I've just tested the whole series, so here's my:
Tested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
WBR, Sergei
prev parent reply other threads:[~2014-08-04 20:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 9:41 Resend: [PATCH 0/4] rcar_vin: fix soc_camera WARN_ON() issues Ian Molton
2014-07-08 9:41 ` [PATCH 1/4] media: rcar_vin: Dont aggressively retire buffers Ian Molton
2014-07-08 9:41 ` [PATCH 2/4] media: rcar_vin: Ensure all in-flight buffers are returned to error state before stoppin Ian Molton
2014-08-04 20:39 ` [PATCH 2/4] media: rcar_vin: Ensure all in-flight buffers are returned to error state before sto Sergei Shtylyov
2014-08-13 17:30 ` Ian Molton
2014-08-13 17:35 ` Sergei Shtylyov
2014-09-20 6:59 ` Guennadi Liakhovetski
2014-08-04 21:22 ` Hans Verkuil
2015-01-18 20:32 ` Guennadi Liakhovetski
2014-07-08 9:41 ` [PATCH 3/4] media: rcar_vin: Fix race condition terminating stream Ian Molton
2014-07-08 16:09 ` Sergei Shtylyov
2014-07-09 8:16 ` Simon Horman
2014-07-10 10:15 ` Ian Molton
2014-08-01 22:16 ` Sergei Shtylyov
2014-08-04 21:27 ` Hans Verkuil
2014-08-11 11:23 ` Ian Molton
2014-08-11 12:14 ` Hans Verkuil
2014-07-08 9:41 ` [PATCH 4/4] media: rcar_vin: Clean up rcar_vin_irq Ian Molton
2014-08-04 20:00 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DFE654.1000102@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=g.liakhovetski@gmx.de \
--cc=horms@verge.net.au \
--cc=ian.molton@codethink.co.uk \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-media@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=magnus.damm@gmail.com \
--cc=vladimir.barinov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).