From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Thu, 07 Aug 2014 15:31:05 +0000 Subject: Re: [PATCH] ARM: shmobile: koelsch: add VIN1/ADV7180 DT support Message-Id: <53E39BB9.7030809@cogentembedded.com> List-Id: References: <201408020402.14560.sergei.shtylyov@cogentembedded.com> <2131152.vMTPsJUYLQ@wasted.cogentembedded.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Hello. On 08/07/2014 08:01 AM, Magnus Damm wrote: >> Define the Koelsch board dependent part of the VIN1 device node. Add the device >> node for Analog Devices ADV7180 video decoder to I2C2 bus. Add the necessary >> subnodes to interconnect VIN1 and ADV7180 devices. >> Signed-off-by: Sergei Shtylyov >> --- >> This patch is against the 'renesas-devel-v3.16-20140804' tag of Simon Horman's >> 'renesas.git' repo. It requires the 'soc_camera' and 'rcar_vin' device tree >> support patches (already merged to the 'media_tree.git' repo) in order to work. >> arch/arm/boot/dts/r8a7791-koelsch.dts | 35 ++++++++++++++++++++++++++++++++++ >> 1 file changed, 35 insertions(+) >> Index: renesas/arch/arm/boot/dts/r8a7791-koelsch.dts >> =================================>> --- renesas.orig/arch/arm/boot/dts/r8a7791-koelsch.dts >> +++ renesas/arch/arm/boot/dts/r8a7791-koelsch.dts >> @@ -289,6 +289,11 @@ >> renesas,groups = "usb1"; >> renesas,function = "usb1"; >> }; >> + >> + vin1_pins: vin1 { >> + renesas,groups = "vin1_data8", "vin1_clk"; >> + renesas,function = "vin1"; >> + }; >> }; > Quick question: Does this pin description match to the board layout? I Yes, it does. > suspect that clock and data by themselves are not enough. They are enough as BT.656 interconnect is used between VIN1 and ADV7180. > I'm not sure about Koelsch, but in case of older SoCs using the CEU > there were signals used like horizontal and vertical sync and > sometimes even something that was used to determine interlace. The HS and VS/FIELD pins of ADV7180 are left unconnected. There's also ADV7612 connected to VIN0 on this board, there the HSYNC and VSYNC/FIELD pins are connected; however, ADV7612 is not supported yet. > Thanks, > / magnus WBR, Sergei