From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Fri, 05 Sep 2014 15:47:49 +0000 Subject: Re: [PATCH] clk-rcar-gen2: RCAN clock support Message-Id: <5409DB25.3070204@cogentembedded.com> List-Id: References: <201407310023.43605.sergei.shtylyov@cogentembedded.com> <540772A1.8080101@cogentembedded.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Geert Uytterhoeven Cc: Mike Turquette , "linux-kernel@vger.kernel.org" , Linux-sh list , Pavel Kiryukhin , Laurent Pinchart On 09/05/2014 01:17 PM, Geert Uytterhoeven wrote: >>>> Add RCAN clock support to the R-Car generation 2 CPG driver. This clock >>>> gets >>>> derived from the USB_EXTAL clock by dividing it by 6. The layout of >>>> RCANCKCR >>>> register is close to those of the clocks supported by the 'clk-div6' >>>> driver >>>> but has no divider field, and so can't be supported by that driver... >> I'm not a clock expert (pulling in Laurent), but it looks fine to me. > While you did add the rcan clock to the dtsi in "[PATCH v3 1/3] ARM: > shmobile: r8a7791: add CAN clocks", I couldn't find a patch to update > the renesas,rcar-gen2-cpg-clocks binding doc? Thanks, I didn't know I need to update the bindings as well... > Gr{oetje,eeting}s, > Geert WBR, Sergei