linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/4] usb: renesas_usbhs: gadget: fix NULL pointer dereference in ep_disable()
Date: Thu, 11 Sep 2014 00:23:52 +0000	[thread overview]
Message-ID: <5410EB98.9060203@renesas.com> (raw)
In-Reply-To: <54102904.6060703@renesas.com>

Hi Morimoto-san,

(2014/09/11 8:56), Kuninori Morimoto wrote:
> 
> Hi Shimoda-san
> 
>> --- a/drivers/usb/renesas_usbhs/mod_gadget.c
>> +++ b/drivers/usb/renesas_usbhs/mod_gadget.c
>> @@ -602,6 +602,9 @@ static int usbhsg_ep_disable(struct usb_ep *ep)
>>  	struct usbhsg_uep *uep = usbhsg_ep_to_uep(ep);
>>  	struct usbhs_pipe *pipe = usbhsg_uep_to_pipe(uep);
>>
>> +	if (!uep || !uep->pipe)
>> +		return -EINVAL;
>> +
>>  	usbhsg_pipe_disable(uep);
>>  	usbhs_pipe_free(pipe);
> 
> If uep can be NULL,
> we need care about usbhsg_uep_to_pipe(uep) too.

Thank you for the point.
I will check the uep can be NULL or not.

> and, "uep->pipe" is same as "pipe" ?

Yes. I will use "pipe" instead of "uep->pipe".

Best regards,
Yoshihiro Shimoda

> Best regards
> ---
> Kuninori Morimoto
> 

      parent reply	other threads:[~2014-09-11  0:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-10 10:33 [PATCH 1/4] usb: renesas_usbhs: gadget: fix NULL pointer dereference in ep_disable() Yoshihiro Shimoda
2014-09-10 13:49 ` Felipe Balbi
2014-09-10 23:56 ` Kuninori Morimoto
2014-09-11  0:18 ` Yoshihiro Shimoda
2014-09-11  0:23 ` Yoshihiro Shimoda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5410EB98.9060203@renesas.com \
    --to=yoshihiro.shimoda.uh@renesas.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).