Re: [PATCH v2] tmio_mmc_pio: prevent endless loop in tmio_mmc_set_clock()

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

    Sorry for delay: I'm on vacations and WiFi didn't work well here...

On 09/08/2014 03:17 PM, Ulf Hansson wrote:

>> I spent a couple of days with the driver just hanging due to me forgetting to
>> specify the external crystal frequency,  so that clk_get_rate() returned 0 and
>> thus the loop in tmio_mmc_set_clock() never ended. I don't think that's an
>> acceptable behavior, so I suggest that the minimum frequency is checked for 0
>> in tmio_mmc_host_probe().

>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

>> ---
>> The patch is against Ulf Hansson's 'mmc.git' repo's 'fixes' branch.

> Hi Sergei,

> Could you please base it towards "next" instead, it doesn't apply. If
> you think this is important to go stable, I suggest you to add a
> stable tag for it.

    It's a bit of a corner case, of course, but the consequences are just too 
disastrous: AFAIR, an ARM kernel just silently hangs on boot, with no hints of 
where. So I'm going to CC: -stable.

> Kind regards
> Uffe

WBR, Sergei