Re: [PATCH 1/2] arm: shimobile: r8a7790: add HS-USB device node

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 10/02/2014 03:40 PM, Yoshihiro Shimoda wrote:

>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>> ---
>>>    arch/arm/boot/dts/r8a7790.dtsi |   10 ++++++++++
>>>    1 file changed, 10 insertions(+)

>>> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
>>> index 2380fd5..fd9fc37 100644
>>> --- a/arch/arm/boot/dts/r8a7790.dtsi
>>> +++ b/arch/arm/boot/dts/r8a7790.dtsi
>>> @@ -1314,4 +1314,14 @@
>>>                ssi9: ssi@9 { interrupts = <0 379 IRQ_TYPE_LEVEL_HIGH>; };
>>>            };
>>>        };
>>> +
>>> +    hsusb: usb@e6590000 {
>>> +        compatible = "renesas,usbhs-r8a7790";
>>> +        reg = <0 0xe6590000 0 0x100>;
>>> +        interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>;
>>> +        clocks = <&mstp7_clks R8A7790_CLK_HSUSB>;

>>     I don't see where are you handling this prop in the driver...

> Thank you for the point. I misunderstood this prop.
> Since the driver is using pm_runtime functions, I thought that
> this device node needs this prop.

    Ah, I've overlooked the RPM related code. No need to remove the prop then.

WBR, Sergei