From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Thu, 02 Oct 2014 22:43:37 +0000 Subject: Re: [PATCH 1/2] arm: shimobile: r8a7790: add HS-USB device node Message-Id: <542DD519.2090805@cogentembedded.com> List-Id: References: <1412237073-1288-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <1412237073-1288-2-git-send-email-yoshihiro.shimoda.uh@renesas.com> In-Reply-To: <1412237073-1288-2-git-send-email-yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yoshihiro Shimoda , horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org, magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote: > Signed-off-by: Yoshihiro Shimoda > --- > arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi > index 2380fd5..fd9fc37 100644 > --- a/arch/arm/boot/dts/r8a7790.dtsi > +++ b/arch/arm/boot/dts/r8a7790.dtsi > @@ -1314,4 +1314,14 @@ > ssi9: ssi@9 { interrupts = <0 379 IRQ_TYPE_LEVEL_HIGH>; }; > }; > }; > + > + hsusb: usb@e6590000 { > + compatible = "renesas,usbhs-r8a7790"; > + reg = <0 0xe6590000 0 0x100>; > + interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&mstp7_clks R8A7790_CLK_HSUSB>; > + renesas,buswait_bwait = <4>; > + phys = <&usb0 1>; > + phy-names = "usb"; > + }; I think the better placement would be prior to USB PHY node, not at the end of the file. WBR, Sergei