From: Khiem Nguyen <khiem.nguyen.xt@renesas.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: r8a7790: switch from scif to scifa
Date: Thu, 02 Oct 2014 23:14:48 +0000 [thread overview]
Message-ID: <542DDC68.80704@renesas.com> (raw)
In-Reply-To: <1410883837-5611-1-git-send-email-wsa@the-dreams.de>
Hi Wolfram, Simon,
Though the patch was already queued up by Simon,
I'd like to confirm one point in changelog.
On 10/2/2014 9:12 AM, Simon Horman wrote:
[snip]
>>>>>>>>>> On Tuesday 16 September 2014 18:10:37 Wolfram Sang wrote:
>>>>>>>>>>> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>>>>>>>>>>>
>>>>>>>>>>> SCIF and SCIFA can be plexed onto the same wires on Lager board.
>>>>>>>>>>> The datasheet also describes the wires as SCIFA. So, to make use
>>>>>>>>>>> of the bigger FIFOs switch to SCIFA instead.
Which datasheet you are mentioned about ?
I checked Lager board datasheet rev0.09 and it said debug interface is SCIF0 and SCIF1.
[snip]
>>>>>>>>>>> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[snip]
>>>>>>>>>>> Currently, I use this patch to check if the DMA RX issue is the
>>>>>>>>>>> same on SCIF and SCIFA (yes, it is). However, I still think it
>>>>>>>>>>> makes sense to use the bigger FIFOs. I will check this next week
>>>>>>>>>>> with Bastian's FIFO patches. Until then, I send this as RFC to
>>>>>>>>>>> collect opinions speaking for/against this change.
[snip]
>>>>>>>>>> I have nothing against this change, but I believe the aliases should
>>>>>>>>>> now be serial0 and serial1 to match the legacy code (OK, that's a
>>>>>>>>>> lame excuse, we all know that I just want to change the aliases
>>>>>>>>>> ;-)).
[snip]
>>>>> This patch switches the Lager board to use SCIFA[01] instead of SCIF[01],
>>>>> while keeping the Linux devices named /dev/ttySC[67]. With legacy boot,
>>>>> SCIFA[01] are named /dev/ttySC[01]. There would thus be a mismatch in that
>>>>> sense, even if this change doesn't prevent using the same Linux serial
>>>>> devices on both legacy and DT boot.
[snip]
>>>> So if I understand if correctly, booting with the current
>>>> "console=ttySC6,115200"
>>>> in /chosen/bootargs will give a working console for both legacy and
>>>> multi-platform,
>>>> but the underlying serial hardware block for the console differs (legacy
>>>> uses SCIF0, multi-platform uses SCIFA0)?
[snip]
>> I will confer with Magnus as he has had strong opinions in this area
>> in the past.
[snip]
> Magnus also seems happy with this change so I have queued it up.
--
Best regards,
KHIEM Nguyen
next prev parent reply other threads:[~2014-10-02 23:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 16:10 [PATCH] ARM: shmobile: r8a7790: switch from scif to scifa Wolfram Sang
2014-09-17 14:40 ` Laurent Pinchart
2014-09-17 23:55 ` Simon Horman
2014-09-18 7:57 ` Laurent Pinchart
2014-09-19 3:28 ` Simon Horman
2014-09-30 4:30 ` Simon Horman
2014-09-30 10:40 ` Laurent Pinchart
2014-09-30 10:44 ` Geert Uytterhoeven
2014-09-30 10:48 ` Laurent Pinchart
2014-09-30 23:58 ` Simon Horman
2014-10-02 0:12 ` Simon Horman
2014-10-02 23:14 ` Khiem Nguyen [this message]
2014-10-03 0:13 ` Wolfram Sang
2014-10-03 3:25 ` Khiem Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542DDC68.80704@renesas.com \
--to=khiem.nguyen.xt@renesas.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).