From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Mon, 06 Oct 2014 10:32:48 +0000 Subject: Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB Message-Id: <54326FD0.8030106@cogentembedded.com> List-Id: References: <1412237073-1288-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <1412237073-1288-3-git-send-email-yoshihiro.shimoda.uh@renesas.com> <542EFDEA.2030906@cogentembedded.com> <5431E984.6000203@renesas.com> In-Reply-To: <5431E984.6000203@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yoshihiro Shimoda , "horms@verge.net.au" , "magnus.damm@gmail.com" , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "linux@arm.linux.org.uk" Cc: "devicetree@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-sh@vger.kernel.org" Hello. On 10/6/2014 4:59 AM, Yoshihiro Shimoda wrote: >>> Signed-off-by: Yoshihiro Shimoda >>> --- >>> arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts >>> index 1698591..4badd0a 100644 >>> --- a/arch/arm/boot/dts/r8a7790-lager.dts >>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts >>> @@ -445,3 +445,8 @@ >>> }; >>> }; >>> }; >>> + >>> +&hsusb { >>> + status = "okay"; >>> + renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_LOW>; >> It's certainly active-high. > Since the current code has the following, we have to set the active_low... Exactly opposite conclusion follows from this code. > However, the code is unreadable, I think. So, I will modify the code. There's no dire need, I think. > /* check GPIO determining if USB function should be enabled */ > if (priv->dparam.enable_gpio) { > gpio_request_one(priv->dparam.enable_gpio, GPIOF_IN, NULL); > ret = !gpio_get_value(priv->dparam.enable_gpio); > gpio_free(priv->dparam.enable_gpio); > if (ret) { 'ret' is non-zero here if gpio_get_value() returned 0, so 0 means "host" and 1 means "gadget", i.e. GPIO is active-high. > dev_warn(&pdev->dev, > "USB function not selected (GPIO %d)\n", > priv->dparam.enable_gpio); > ret = -ENOTSUPP; > goto probe_end_mod_exit; > } > } > Best regards, > Yoshihiro Shimoda WBR, Sergei