linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: shmobile: koelsch: Fix flash partition label and size in device tree
@ 2014-10-30  5:54 Simon Horman
  2014-10-30 10:23 ` Geert Uytterhoeven
  0 siblings, 1 reply; 3+ messages in thread
From: Simon Horman @ 2014-10-30  5:54 UTC (permalink / raw)
  To: linux-arm-kernel

From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>

The size and the name of flash partition are consistent
across use the R-Car Gen2 series.

This patch makes the koelsch board consistent with the lager board.

Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
[simon: reworded changelog]
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
Based on the renesas-devel-20141030-v3.18-rc2 branch of my renesas tree

 arch/arm/boot/dts/r8a7791-koelsch.dts | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
index 523ae4d..90587f0 100644
--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
@@ -390,17 +390,17 @@
 
 		partition@0 {
 			label = "loader";
-			reg = <0x00000000 0x00080000>;
+			reg = <0x00000000 0x00040000>;
 			read-only;
 		};
-		partition@80000 {
-			label = "bootenv";
-			reg = <0x00080000 0x00080000>;
+		partition@40000 {
+			label = "user";
+			reg = <0x00040000 0x00400000>;
 			read-only;
 		};
-		partition@100000 {
-			label = "data";
-			reg = <0x00100000 0x03f00000>;
+		partition@440000 {
+			label = "flash";
+			reg = <0x00440000 0x03bc0000>;
 		};
 	};
 };
-- 
2.1.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: shmobile: koelsch: Fix flash partition label and size in device tree
  2014-10-30  5:54 [PATCH] ARM: shmobile: koelsch: Fix flash partition label and size in device tree Simon Horman
@ 2014-10-30 10:23 ` Geert Uytterhoeven
  2014-10-30 10:50   ` Chai Wen
  0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2014-10-30 10:23 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Oct 30, 2014 at 6:54 AM, Simon Horman
<horms+renesas@verge.net.au> wrote:
> From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
>
> The size and the name of flash partition are consistent
> across use the R-Car Gen2 series.
>
> This patch makes the koelsch board consistent with the lager board.

Does this match the actual data in the FLASH?

On my board, the SPI boot loader is at 0x00000000.
There's also a small unidentified chunk at 0x00040000:

    00040000  00 40 30 e6 5c 3a 03 00  ff ff ff ff ff ff ff ff
|.@0.\:..........|

u-Boot seems to be at 0x00080000.
u-Boot environment variables are saved at 0x000c0000.
This does match the old "bootenv" partition.

After that it's all-zeroes until 0x00100000, where I did my SPI tests,
based on the old layout.

Do I have a non-standard Koelsch FLASH layout on my board?

> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> @@ -390,17 +390,17 @@
>
>                 partition@0 {
>                         label = "loader";
> -                       reg = <0x00000000 0x00080000>;
> +                       reg = <0x00000000 0x00040000>;
>                         read-only;
>                 };
> -               partition@80000 {
> -                       label = "bootenv";
> -                       reg = <0x00080000 0x00080000>;
> +               partition@40000 {
> +                       label = "user";
> +                       reg = <0x00040000 0x00400000>;
>                         read-only;
>                 };
> -               partition@100000 {
> -                       label = "data";
> -                       reg = <0x00100000 0x03f00000>;
> +               partition@440000 {
> +                       label = "flash";
> +                       reg = <0x00440000 0x03bc0000>;
>                 };
>         };
>  };

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: shmobile: koelsch: Fix flash partition label and size in device tree
  2014-10-30 10:23 ` Geert Uytterhoeven
@ 2014-10-30 10:50   ` Chai Wen
  0 siblings, 0 replies; 3+ messages in thread
From: Chai Wen @ 2014-10-30 10:50 UTC (permalink / raw)
  To: linux-arm-kernel

On 10/30/2014 06:23 PM, Geert Uytterhoeven wrote:

> On Thu, Oct 30, 2014 at 6:54 AM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
>> From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
>>
>> The size and the name of flash partition are consistent
>> across use the R-Car Gen2 series.
>>
>> This patch makes the koelsch board consistent with the lager board.
> 
> Does this match the actual data in the FLASH?
> 
> On my board, the SPI boot loader is at 0x00000000.
> There's also a small unidentified chunk at 0x00040000:
> 
>     00040000  00 40 30 e6 5c 3a 03 00  ff ff ff ff ff ff ff ff
> |.@0.\:..........|
> 
> u-Boot seems to be at 0x00080000.
> u-Boot environment variables are saved at 0x000c0000.
> This does match the old "bootenv" partition.
> 
> After that it's all-zeroes until 0x00100000, where I did my SPI tests,
> based on the old layout.
> 
> Do I have a non-standard Koelsch FLASH layout on my board?



FYI, I have a koelsch board, and the layout out the flash is like:

0x0            0x10000               0x50000            
|-- loader.bin --|--    uboot.bin    --|--           something else  --|
0               64K                   320K                             16M

But, I have no idea whether this is a standard layout or not.

thanks
chai wen

> 
>> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
>> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
>> @@ -390,17 +390,17 @@
>>
>>                 partition@0 {
>>                         label = "loader";
>> -                       reg = <0x00000000 0x00080000>;
>> +                       reg = <0x00000000 0x00040000>;
>>                         read-only;
>>                 };
>> -               partition@80000 {
>> -                       label = "bootenv";
>> -                       reg = <0x00080000 0x00080000>;
>> +               partition@40000 {
>> +                       label = "user";
>> +                       reg = <0x00040000 0x00400000>;
>>                         read-only;
>>                 };
>> -               partition@100000 {
>> -                       label = "data";
>> -                       reg = <0x00100000 0x03f00000>;
>> +               partition@440000 {
>> +                       label = "flash";
>> +                       reg = <0x00440000 0x03bc0000>;
>>                 };
>>         };
>>  };
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> .
> 



-- 
Regards

Chai Wen

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-10-30 10:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-30  5:54 [PATCH] ARM: shmobile: koelsch: Fix flash partition label and size in device tree Simon Horman
2014-10-30 10:23 ` Geert Uytterhoeven
2014-10-30 10:50   ` Chai Wen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).