From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Courbot Date: Fri, 14 Nov 2014 08:38:58 +0000 Subject: Re: [PATCH v3] of: replace Asahi Kasei Corp venter prefix Message-Id: <5465BFA2.9050706@nvidia.com> List-Id: References: <5398AB07.4040304@wwwdotorg.org> <87sinbdk44.wl%kuninori.morimoto.gx@renesas.com> <878ulzx6hr.wl%kuninori.morimoto.gx@gmail.com> <20140922130026.GK3290@leverpostej> <20140922132743.GM3290@leverpostej> <87y4rfhmgl.wl%kuninori.morimoto.gx@renesas.com> <1415845309.4269.6.camel@perches.com> <20141113025105.GA16652@verge.net.au> <87vbmjhj00.wl%kuninori.morimoto.gx@renesas.com> <20141113110740.GE3815@sirena.org.uk> <87k32yd0bd.wl%kuninori.morimoto.gx@renesas.com> In-Reply-To: <87k32yd0bd.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Kuninori Morimoto , Mark Brown , Mark Rutland Cc: Simon Horman , Joe Perches , Geert Uytterhoeven , Kuninori Morimoto , Olof Johansson , Stephen Warren , Rob Herring , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , ALSA Development Mailing List , Linux-sh list , Magnus , "grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On 11/14/2014 10:43 AM, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > Current vendor-prefixes.txt already has > "ak" prefix for Asahi Kasei Corp by > ae8c4209af2cec065fef15d200a42a04130799f7 > (of: Add vendor prefix for Asahi Kasei Corp.) > > It went through the appropriate review process. > But, almost all Asahi Kasei chip drivers are > using "asahi-kasei" prefix today. > (arch/arm/boot/dts/tegra20-seaboard.dts only is > using "ak,ak8975", but there are instances of > "asahi-kasei,ak8975" in other dts files. > And drivers/iio/magnetometer/ak8975.c > doesn't support "ak,ak8975") > So, we made a mistake there. > > In addition, checkpatch.pl reports WARNING > if it is using "asahi-kasei" prerfix in DT file. > (DT compatible string vendor "asahi-kasei" appears un-documented) > > Marking it deprecated and warning with checkpatch > is certainly preferable. > So, this patch replace "ak" to "asahi-kasei" in > vendor-prefixes.txt. (and fixup tegra20-seaboard) > > OTOH, Asahi Kasei is usually referred to as "AKM", > but this patch doesn't care about it. > Because no DT is using that today. > > Signed-off-by: Kuninori Morimoto > --- > .../devicetree/bindings/vendor-prefixes.txt | 2 +- > arch/arm/boot/dts/tegra20-seaboard.dts | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt > index 723999d..ddcb4cd 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt > @@ -9,7 +9,6 @@ ad Avionic Design GmbH > adapteva Adapteva, Inc. > adi Analog Devices, Inc. > aeroflexgaisler Aeroflex Gaisler AB > -ak Asahi Kasei Corp. > allwinner Allwinner Technology Co., Ltd. > altr Altera Corp. > amcc Applied Micro Circuits Corporation (APM, formally AMCC) > @@ -20,6 +19,7 @@ amstaos AMS-Taos Inc. > apm Applied Micro Circuits Corporation (APM) > arm ARM Ltd. > armadeus ARMadeus Systems SARL > +asahi-kasei Asahi Kasei Corp. > atmel Atmel Corporation > auo AU Optronics Corporation > avago Avago Technologies > diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts > index a1d4bf9..7f5cf80 100644 > --- a/arch/arm/boot/dts/tegra20-seaboard.dts > +++ b/arch/arm/boot/dts/tegra20-seaboard.dts > @@ -405,7 +405,7 @@ > clock-frequency = <400000>; > > magnetometer@c { > - compatible = "ak,ak8975"; > + compatible = "asahi-kasei,ak8975"; Mmm. So does this mean this device was never probed because the driver did not recognize its compatible property? I cannot find "ak,ak8975" anywhere else in the kernel. If so, Acked-by: Alexandre Courbot