From: Sudeep Holla <sudeep.holla@arm.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] ARM: shmobile: r8a7790 CCI configuration
Date: Tue, 25 Nov 2014 10:04:42 +0000 [thread overview]
Message-ID: <5474543A.807@arm.com> (raw)
In-Reply-To: <54743D0F.5080307@bp.renesas.com>
On 25/11/14 08:25, Gaku Inami wrote:
> Add the settings of CCI-400 for enabling ca15/ca7 snoop on r8a7790.
> Needed to configure the CCI boot cluster port regardless of MCPM.
>
> Signed-off-by: Gaku Inami <gaku.inami.xw@bp.renesas.com>
> Signed-off-by: Magnus Damm <damm@opensource.se>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>
> Changes since version 1:
> - Fix a way to wait for the register read.
>
> arch/arm/mach-shmobile/smp-r8a7790.c | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm/mach-shmobile/smp-r8a7790.c b/arch/arm/mach-shmobile/smp-r8a7790.c
> index 9c3da13..b65d908 100644
> --- a/arch/arm/mach-shmobile/smp-r8a7790.c
> +++ b/arch/arm/mach-shmobile/smp-r8a7790.c
> @@ -25,6 +25,12 @@
> #include "pm-rcar.h"
> #include "r8a7790.h"
>
> +#define CCI_BASE 0xf0090000
> +#define CCI_SLAVE3 0x4000
> +#define CCI_SLAVE4 0x5000
> +#define CCI_SNOOP 0x0000
> +#define CCI_STATUS 0x000c
> +
I have asked the same question multiple times in the past, why are you
not using the DT bindings and the CCI driver for this ? Why are you
duplicating the code ? Any limitations to use them ?
Regards,
Sudeep
next prev parent reply other threads:[~2014-11-25 10:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 8:25 [PATCH v2] ARM: shmobile: r8a7790 CCI configuration Gaku Inami
2014-11-25 10:04 ` Sudeep Holla [this message]
2014-11-26 1:25 ` Gaku Inami
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5474543A.807@arm.com \
--to=sudeep.holla@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).