From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudeep Holla Date: Tue, 25 Nov 2014 10:04:42 +0000 Subject: Re: [PATCH v2] ARM: shmobile: r8a7790 CCI configuration Message-Id: <5474543A.807@arm.com> List-Id: References: <54743D0F.5080307@bp.renesas.com> In-Reply-To: <54743D0F.5080307@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On 25/11/14 08:25, Gaku Inami wrote: > Add the settings of CCI-400 for enabling ca15/ca7 snoop on r8a7790. > Needed to configure the CCI boot cluster port regardless of MCPM. > > Signed-off-by: Gaku Inami > Signed-off-by: Magnus Damm > Signed-off-by: Simon Horman > --- > > Changes since version 1: > - Fix a way to wait for the register read. > > arch/arm/mach-shmobile/smp-r8a7790.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm/mach-shmobile/smp-r8a7790.c b/arch/arm/mach-shmobile/smp-r8a7790.c > index 9c3da13..b65d908 100644 > --- a/arch/arm/mach-shmobile/smp-r8a7790.c > +++ b/arch/arm/mach-shmobile/smp-r8a7790.c > @@ -25,6 +25,12 @@ > #include "pm-rcar.h" > #include "r8a7790.h" > > +#define CCI_BASE 0xf0090000 > +#define CCI_SLAVE3 0x4000 > +#define CCI_SLAVE4 0x5000 > +#define CCI_SNOOP 0x0000 > +#define CCI_STATUS 0x000c > + I have asked the same question multiple times in the past, why are you not using the DT bindings and the CCI driver for this ? Why are you duplicating the code ? Any limitations to use them ? Regards, Sudeep