From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Tue, 06 Jan 2015 19:59:08 +0000
Subject: Re: [PATCH 3/6] ARM: shmobile: kzm9g-reference dts: Add ak8975 magnetometer node
Message-Id: <54AC3E8C.7090803@cogentembedded.com>
List-Id: <linux-sh.vger.kernel.org>
References: <1420573329-12762-4-git-send-email-geert+renesas@glider.be>
In-Reply-To: <1420573329-12762-4-git-send-email-geert+renesas@glider.be>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: linux-sh@vger.kernel.org

On 01/06/2015 10:53 PM, Geert Uytterhoeven wrote:

>>> Add a DT node for the AK8975 magnetometer sensor, which is connected to
>>> i2c0.

>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

>>> Specify the device interrupt to avoid polling for end of conversion.

>>> While at it rename the DT node to compass@c to describe the device's
>>> function instead of its model.

>>> Signed-off-by: Laurent Pinchart
>>> <laurent.pinchart+renesas@ideasonboard.com>
>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

>>     You signed off on the patch twice?

> Yep. I don't know a better way to squash other people's updates into
> an earlier commit.

    Hmm... it's still not clear to me whose changes are where. Whose patch 
that was originally?

[...]

>>> diff --git a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
>>> b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
>>> index 02fc265332e8fb84..beabc3fd013b9ff0 100644
>>> --- a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
>>> +++ b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
>>> @@ -189,6 +189,13 @@
>>>    &i2c0 {
>>>          status = "okay";
>>>
>>> +       compass@c {
>>> +               compatible = "asahi-kasei,ak8975";
>>> +               reg = <0x0c>;

>>     Just 0xc?

> Yep. This is an i2c bus.

    Yeah, I do understand. I was suggesting to remove '0' after 'x'.

> Gr{oetje,eeting}s,
>                          Geert

WBR, Sergei