linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] dma: rcar-hpbdma: add dma_dev->directions
Date: Wed, 07 Jan 2015 14:22:01 +0000	[thread overview]
Message-ID: <54AD4109.8050903@metafoo.de> (raw)
In-Reply-To: <87r3v8uy5p.wl%kuninori.morimoto.gx@renesas.com>

On 01/06/2015 09:10 AM, Kuninori Morimoto wrote:
[...]
>   	dma_cap_set(DMA_SLAVE, dma_dev->cap_mask);
> +	dma_dev->directions = BIT(DMA_MEM_TO_DEV) | BIT(DMA_DEV_TO_MEM);

You should also set the other capabilities: src_addr_widths, dst_addr_widths 
and residue_granularity.

- Lars


      reply	other threads:[~2015-01-07 14:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-06  8:10 [PATCH] dma: rcar-hpbdma: add dma_dev->directions Kuninori Morimoto
2015-01-07 14:22 ` Lars-Peter Clausen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54AD4109.8050903@metafoo.de \
    --to=lars@metafoo.de \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).