From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Sat, 17 Jan 2015 22:06:51 +0000 Subject: Re: [PATCH] clk-gate: fix bit # check in clk_register_gate() Message-Id: <54BADCFB.5010805@cogentembedded.com> List-Id: References: <2500887.6mMDBajo0S@wasted.cogentembedded.com> <20150117220116.22722.808@quantum> In-Reply-To: <20150117220116.22722.808@quantum> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mike Turquette , linux-kernel@vger.kernel.org, sboyd@codeaurora.org Cc: linux-sh@vger.kernel.org Hello. On 01/18/2015 01:01 AM, Mike Turquette wrote: >> In case CLK_GATE_HIWORD_MASK flag is passed to clk_register_gate(), the bit # >> should be no higher than 15, however the corresponding check is obviously off- >> by-one. >> Fixes: 045779942c04 ("clk: gate: add CLK_GATE_HIWORD_MASK") >> Signed-off-by: Sergei Shtylyov > Applied to clk-next. Thanks! Is this causing a visible regression for > you? It is not a new bug so I'd prefer to send it though clk-next unless > something is blowing up on your end. No, nothing, I don't even call this function (was using composite clock). Found by just looking at the code. >> --- >> The patch is against Linus' repo because the 'clk-fixes' branch in Mike >> Turquette's 'linux.git' repo at Linaro seems very outdated. BTW, the repo >> at kernel.org specified by the MAINTAINERS file doesn't seem to exist -- >> can something be done about that? > The clk-fixes branch at git.linaro.org is now updated and the clk tree > at git.kernel.org is also live. Blame the holidays. > For now they will mirror each other (and linux-next will continue to > reference the one at git.linaro.org until 3.19 is released). Thank you. > Regards, > Mike WBR, Sergei