From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Sun, 25 Jan 2015 16:57:09 +0000 Subject: Re: [PATCH] serial: sh-sci: Fix R-Car SCIF and HSCIF overrun handling Message-Id: <54C52065.8030600@cogentembedded.com> List-Id: References: <1422200281-22518-1-git-send-email-ykaneko0929@gmail.com> In-Reply-To: <1422200281-22518-1-git-send-email-ykaneko0929@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yoshihiro Kaneko , linux-serial@vger.kernel.org Cc: Greg Kroah-Hartman , Simon Horman , Magnus Damm , linux-sh@vger.kernel.org Hello. On 01/25/2015 06:38 PM, Yoshihiro Kaneko wrote: > From: Hisashi Nakamura > When fifo overrun happened, the interrupt status refers to > SCLSR register in R-Car SCIF and HSCIF. > Thus, overrun handling takes SCLSR register into account. > Signed-off-by: Hisashi Nakamura > Signed-off-by: Yoshihiro Kaneko [...] > diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c > index 8204306..69f6bf3 100644 > --- a/drivers/tty/serial/sh-sci.c > +++ b/drivers/tty/serial/sh-sci.c [...] > @@ -1032,6 +1038,12 @@ static irqreturn_t sci_mpxed_interrupt(int irq, void *ptr) > if ((ssr_status & SCxSR_BRK(port)) && err_enabled) > ret = sci_br_interrupt(irq, ptr); > > + /* Overrun Interrupt */ > + if (port->type = PORT_SCIF || port->type = PORT_HSCIF) { > + if ((slr_status & 0x01)) No need for double parens. WBR, Sergei