From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 2/6] dmaengine: rcar-dmac: Fix spinlock issues in interrupt
Date: Tue, 27 Jan 2015 18:19:04 +0000 [thread overview]
Message-ID: <54C7D698.1070201@cogentembedded.com> (raw)
In-Reply-To: <1422379516-1633-3-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
Hello.
On 01/27/2015 08:25 PM, Laurent Pinchart wrote:
[...]
> Furthermore, as the driver can be used on SMP systems, the IRQ handlers
> must use spin_lock_irqsave() instead of spin_lock().
Hmm, care to explain why? It's the first time I'm hearing that...
This looks especially strange in the context of the current genirq code
calling IRQ handlers with interrupts always disabled.
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
WBR, Sergei
next prev parent reply other threads:[~2015-01-27 18:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 17:25 [PATCH 2/6] dmaengine: rcar-dmac: Fix spinlock issues in interrupt Laurent Pinchart
2015-01-27 18:19 ` Sergei Shtylyov [this message]
2015-01-27 18:55 ` Laurent Pinchart
2015-01-27 19:01 ` Sergei Shtylyov
2015-01-27 19:08 ` Laurent Pinchart
2015-01-27 19:12 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C7D698.1070201@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).