* Re: [PATCH v3] sh-pfc: add R8A7794 PFC support
[not found] <2084538.pWCX8EzoLe@wasted.cogentembedded.com>
@ 2015-02-22 22:39 ` Laurent Pinchart
2015-02-25 20:03 ` Sergei Shtylyov
2015-03-06 10:34 ` Linus Walleij
2 siblings, 0 replies; 5+ messages in thread
From: Laurent Pinchart @ 2015-02-22 22:39 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: linus.walleij, linux-sh, linux-gpio, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, devicetree
Hi Sergei,
Thank you for the patch.
On Monday 23 February 2015 00:33:38 Sergei Shtylyov wrote:
> From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
>
> Add PFC support for the R8A7794 SoC including pin groups for some on-chip
> devices such as ETH, I2C, INTC, MSIOF, QSPI, [H]SCIF...
>
> Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> [Sergei: squashed together several patches, fixed the MLB_CLK typo, added
> IRQ4.. IRQ9 pin groups, fixed IRQn comments, added ETH B pin group names,
> removed stray new line and fixed typos in the comments in the
> pinmux_config_regs[] initializer, removed the platform device ID, took into
> account limited number of signals in the GPIO1/5/6 controllers, added
> reasonable and removed unreasonable copyrights, modified the bindings
> document, renamed, added changelog.] Signed-off-by: Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes in version 3:
> - removed the platform device ID;
> - added PORT_GP_26() and PORT_GP_28() macros, used them for GPIO1/5/6 in the
> CPU_ALL_PORT() macto.
>
> Changes in version 2:
> - rebased the patch.
>
> Documentation/devicetree/bindings/pinctrl/renesas,pfc-pinctrl.txt | 1
> drivers/pinctrl/sh-pfc/Kconfig | 5
> drivers/pinctrl/sh-pfc/Makefile | 1
> drivers/pinctrl/sh-pfc/core.c | 6
> drivers/pinctrl/sh-pfc/core.h | 1
> drivers/pinctrl/sh-pfc/pfc-r8a7794.c | 4020 ++
> 6 files changed, 4034 insertions(+)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3] sh-pfc: add R8A7794 PFC support
[not found] <2084538.pWCX8EzoLe@wasted.cogentembedded.com>
2015-02-22 22:39 ` [PATCH v3] sh-pfc: add R8A7794 PFC support Laurent Pinchart
@ 2015-02-25 20:03 ` Sergei Shtylyov
2015-02-25 23:06 ` Sergei Shtylyov
2015-03-06 10:34 ` Linus Walleij
2 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2015-02-25 20:03 UTC (permalink / raw)
To: linus.walleij, linux-sh, laurent.pinchart, linux-gpio
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
devicetree
Hello.
On 02/23/2015 12:33 AM, Sergei Shtylyov wrote:
> From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> Add PFC support for the R8A7794 SoC including pin groups for some on-chip
> devices such as ETH, I2C, INTC, MSIOF, QSPI, [H]SCIF...
> Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> [Sergei: squashed together several patches, fixed the MLB_CLK typo, added IRQ4..
> IRQ9 pin groups, fixed IRQn comments, added ETH B pin group names, removed
> stray new line and fixed typos in the comments in the pinmux_config_regs[]
> initializer, removed the platform device ID, took into account limited number of
> signals in the GPIO1/5/6 controllers, added reasonable and removed unreasonable
> copyrights, modified the bindings document, renamed, added changelog.]
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> ---
> Changes in version 3:
> - removed the platform device ID;
> - added PORT_GP_26() and PORT_GP_28() macros, used them for GPIO1/5/6 in the
> CPU_ALL_PORT() macto.
Don't apply this patch! The change above causes the driver to fail probing
and the eventual kernel hang somehow... :-(
> Changes in version 2:
> - rebased the patch.
WBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3] sh-pfc: add R8A7794 PFC support
2015-02-25 20:03 ` Sergei Shtylyov
@ 2015-02-25 23:06 ` Sergei Shtylyov
0 siblings, 0 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2015-02-25 23:06 UTC (permalink / raw)
To: linus.walleij, linux-sh, laurent.pinchart, linux-gpio
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
devicetree
On 02/25/2015 11:03 PM, Sergei Shtylyov wrote:
>> From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
>> Add PFC support for the R8A7794 SoC including pin groups for some on-chip
>> devices such as ETH, I2C, INTC, MSIOF, QSPI, [H]SCIF...
>> Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
>> [Sergei: squashed together several patches, fixed the MLB_CLK typo, added
>> IRQ4..
>> IRQ9 pin groups, fixed IRQn comments, added ETH B pin group names, removed
>> stray new line and fixed typos in the comments in the pinmux_config_regs[]
>> initializer, removed the platform device ID, took into account limited
>> number of
>> signals in the GPIO1/5/6 controllers, added reasonable and removed unreasonable
>> copyrights, modified the bindings document, renamed, added changelog.]
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
>> ---
>> Changes in version 3:
>> - removed the platform device ID;
>> - added PORT_GP_26() and PORT_GP_28() macros, used them for GPIO1/5/6 in the
>> CPU_ALL_PORT() macto.
> Don't apply this patch! The change above causes the driver to fail probing
> and the eventual kernel hang somehow... :-(
OK, I think I fixed it now. But I'm going to submit the new version of
this patch after that, in order to reuse PORT_GP_26() when defining
PORT_GP_28()...
>> Changes in version 2:
>> - rebased the patch.
WBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] sh-pfc: add R8A7794 PFC support
[not found] <2084538.pWCX8EzoLe@wasted.cogentembedded.com>
2015-02-22 22:39 ` [PATCH v3] sh-pfc: add R8A7794 PFC support Laurent Pinchart
2015-02-25 20:03 ` Sergei Shtylyov
@ 2015-03-06 10:34 ` Linus Walleij
2015-03-06 12:44 ` Sergei Shtylyov
2 siblings, 1 reply; 5+ messages in thread
From: Linus Walleij @ 2015-03-06 10:34 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: linux-sh@vger.kernel.org, Laurent Pinchart,
linux-gpio@vger.kernel.org, Rob Herring, Paweł Moll,
Mark Rutland, ijc+devicetree@hellion.org.uk, Kumar Gala,
devicetree@vger.kernel.org
On Sun, Feb 22, 2015 at 10:33 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
>
> Add PFC support for the R8A7794 SoC including pin groups for some on-chip
> devices such as ETH, I2C, INTC, MSIOF, QSPI, [H]SCIF...
>
> Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> [Sergei: squashed together several patches, fixed the MLB_CLK typo, added IRQ4..
> IRQ9 pin groups, fixed IRQn comments, added ETH B pin group names, removed
> stray new line and fixed typos in the comments in the pinmux_config_regs[]
> initializer, removed the platform device ID, took into account limited number of
> signals in the GPIO1/5/6 controllers, added reasonable and removed unreasonable
> copyrights, modified the bindings document, renamed, added changelog.]
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> Changes in version 3:
This v3 applied with Laurent's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3] sh-pfc: add R8A7794 PFC support
2015-03-06 10:34 ` Linus Walleij
@ 2015-03-06 12:44 ` Sergei Shtylyov
0 siblings, 0 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2015-03-06 12:44 UTC (permalink / raw)
To: Linus Walleij
Cc: linux-sh@vger.kernel.org, Laurent Pinchart,
linux-gpio@vger.kernel.org, Rob Herring, Paweł Moll,
Mark Rutland, ijc+devicetree@hellion.org.uk, Kumar Gala,
devicetree@vger.kernel.org
On 3/6/2015 1:34 PM, Linus Walleij wrote:
>> From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
>> Add PFC support for the R8A7794 SoC including pin groups for some on-chip
>> devices such as ETH, I2C, INTC, MSIOF, QSPI, [H]SCIF...
>> Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
>> [Sergei: squashed together several patches, fixed the MLB_CLK typo, added IRQ4..
>> IRQ9 pin groups, fixed IRQn comments, added ETH B pin group names, removed
>> stray new line and fixed typos in the comments in the pinmux_config_regs[]
>> initializer, removed the platform device ID, took into account limited number of
>> signals in the GPIO1/5/6 controllers, added reasonable and removed unreasonable
>> copyrights, modified the bindings document, renamed, added changelog.]
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> ---
>> Changes in version 3:
> This v3 applied with Laurent's ACK.
There's v4 already. Anyway, it shouldn't be applied yet.
> Yours,
> Linus Walleij
WBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread