From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Date: Mon, 06 Apr 2015 19:04:21 +0000 Subject: Re: [PATCH 03/14] clkdev: get rid of redundant clk_add_alias() prototype in linux/clk.h Message-Id: <5522D8B5.7050205@codeaurora.org> List-Id: References: <20150403171149.GC13898@n2100.arm.linux.org.uk> <87lhi8rrmd.fsf@free.fr> In-Reply-To: <87lhi8rrmd.fsf@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Robert Jarzmik , Russell King Cc: alsa-devel@alsa-project.org, linux-sh@vger.kernel.org, Kevin Hilman , Sekhar Nori , Haojian Zhuang , Tony Lindgren , Daniel Mack , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org On 04/04/15 05:43, Robert Jarzmik wrote: > Russell King writes: > >> clk_add_alias() is provided by clkdev, and is not part of the clk API. >> Howver, it is prototyped in two locations: linux/clkdev.h and >> linux/clk.h. This is a mess. Get rid of the redundant and unnecessary >> version in linux/clk.h. >> >> Signed-off-by: Russell King > Tested-by: Robert Jarzmik > > Actually, this serie fixes a regression I've seen in linux-next, and which was > triggering the Oops in [1] on lubbock. With your serie, the kernel boots fine. > > Is this with the lubbock_defconfig? Is it a regression in 4.0-rc series or is it due to some pending -next patches interacting with the per-user clock patches? It looks like the latter because __clk_get_hw() should be inlined on lubbock_defconfig where CONFIG_COMMON_CLK=n. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project