Re: [RFC/PATCH 2/4] ARM: shmobile: Add cpuidle_ops for R-Car cpuidle

[keita kobayashi <keita.kobayashi.ym@renesas.com>]

Hi Simon

Thank you for your feedback.

(2015/04/07 10:50), Simon Horman wrote:

> On Mon, Apr 06, 2015 at 12:50:42PM +0900, Keita Kobayashi wrote:
>> This patch add Core-Standby support for R-Car cpuidle.
>>
>> Signed-off-by: Keita Kobayashi <keita.kobayashi.ym@renesas.com>
> 
> [snip]
> 
>> diff --git a/arch/arm/mach-shmobile/pm-rcar-gen2.c b/arch/arm/mach-shmobile/pm-rcar-gen2.c
>> index 6815781..846b8ae 100644
> 
> [snip]
> 
>> +struct cpuidle_ops rcar_cpuidle_ops __initdata = {
>> +	.suspend = rcar_cpuidle_enter,
>> +};
>> +CPUIDLE_METHOD_OF_DECLARE(rcar, "renesas,rcar-idle", &rcar_cpuidle_ops);
>> +#endif
> 
> It seems to me that that renesas,rcar-idle should be documented
> as an enable-method in Documentation/devicetree/bindings/arm/cpus.txt.
> 
> That change could be a separate patch for device tree.

I understand. I will document it.

Regards.
Keita Kobayashi