From mboxrd@z Thu Jan 1 00:00:00 1970 From: Khiem Nguyen Date: Fri, 19 Jun 2015 11:39:38 +0000 Subject: Re: [PATCH] gpio: rcar: Add r8a7795 (R-Car H3) support Message-Id: <5583FF7A.1010205@rvc.renesas.com> List-Id: References: <1434710308-15901-1-git-send-email-ulrich.hecht+renesas@gmail.com> In-Reply-To: <1434710308-15901-1-git-send-email-ulrich.hecht+renesas@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org Hi Ulrich, Thanks for your patch. On 6/19/2015 5:38 PM, Ulrich Hecht wrote: > R-Car Gen3's GPIO blocks are identical to Gen2's in every respect. > > Signed-off-by: Ulrich Hecht > --- > Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt | 1 + > drivers/gpio/gpio-rcar.c | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt > index 38fb86f..f60e2f4 100644 > --- a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt > +++ b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt > @@ -9,6 +9,7 @@ Required Properties: > - "renesas,gpio-r8a7791": for R8A7791 (R-Car M2-W) compatible GPIO controller. > - "renesas,gpio-r8a7793": for R8A7793 (R-Car M2-N) compatible GPIO controller. > - "renesas,gpio-r8a7794": for R8A7794 (R-Car E2) compatible GPIO controller. > + - "renesas,gpio-r8a7795": for R8A7795 (R-Car H3) compatible GPIO controller. > - "renesas,gpio-rcar": for generic R-Car GPIO controller. > > - reg: Base address and length of each memory resource used by the GPIO > diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c > index fd39774..e962ad5 100644 > --- a/drivers/gpio/gpio-rcar.c > +++ b/drivers/gpio/gpio-rcar.c > @@ -318,6 +318,9 @@ static const struct of_device_id gpio_rcar_of_table[] = { > .compatible = "renesas,gpio-r8a7794", > .data = &gpio_rcar_info_gen2, > }, { > + .compatible = "renesas,gpio-r8a7795", > + .data = &gpio_rcar_info_gen2, I suggest that we should create another structure, e.g gpio_rcar_info_gen3, or change current gpio_rcar_info_gen2 to a more generic name for both gen2 and gen3. What do you think ? > + }, { > .compatible = "renesas,gpio-rcar", > .data = &gpio_rcar_info_gen1, > }, { > -- Best regards, KHIEM Nguyen -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in