From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
wg@grandegger.com, linux-can@vger.kernel.org,
Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [PATCH 2/3] rcar_can: print signed IRQ #
Date: Sat, 20 Jun 2015 16:02:19 +0000 [thread overview]
Message-ID: <55858E8B.9000801@pengutronix.de> (raw)
In-Reply-To: <55857AD3.4040000@cogentembedded.com>
[-- Attachment #1: Type: text/plain, Size: 954 bytes --]
On 06/20/2015 04:38 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 6/20/2015 3:03 PM, Geert Uytterhoeven wrote:
>
>>> Printing IRQ # using "%x" and "%u" unsigned formats isn't quite correct as
>>> 'ndev->irq' is of type *int*, so the "%d" format needs to be used instead.
>
>>> While fixing this, beautify the dev_info() message in rcar_can_probe() a bit.
>
>> If you change the message, why don't you make it consistent
>> ("interrupt" vs. "IRQ")?
>
> I decided to change the message in a follow-up patch (posted afterwards).
Please squash you patches, so that you don't modify code (or error
messages) that you've added in a previous patch.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2015-06-20 16:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-20 0:30 [PATCH 0/3] Small fixes for Renesas R-Car CAN driver Sergei Shtylyov
2015-06-20 0:32 ` [PATCH 1/3] rcar_can: fix IRQ check Sergei Shtylyov
2015-06-20 0:33 ` [PATCH 2/3] rcar_can: print signed IRQ # Sergei Shtylyov
2015-06-20 12:03 ` Geert Uytterhoeven
2015-06-20 14:38 ` Sergei Shtylyov
2015-06-20 16:02 ` Marc Kleine-Budde [this message]
2015-06-20 16:25 ` Sergei Shtylyov
2015-06-20 0:34 ` [PATCH 3/3] rcar_can: fix typo in error message Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55858E8B.9000801@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=geert@linux-m68k.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).