From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Fri, 10 Jul 2015 16:36:10 +0000 Subject: Re: [PATCH v3] phy: rcar-gen2 usb: Add Host/Function switching for USB0 Message-Id: <559FF47A.5000001@cogentembedded.com> List-Id: References: <1436270121-25924-1-git-send-email-phil.edworthy@renesas.com> In-Reply-To: <1436270121-25924-1-git-send-email-phil.edworthy-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Phil Edworthy , Kishon Vijay Abraham I Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Yoshihiro Shimoda , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Hello. On 07/07/2015 02:55 PM, Phil Edworthy wrote: > Instead of statically selecting the PHY connection to either the > USBHS (Function) or PCI0 (Host) IP blocks, this change allows the > dts to specifiy gpio pins for the vbus and id signals. Additional These GPIOs don't have anything to do with the PHY, they're interfacing Maxim MAX3355 OTG chip for which I have submitted the extcon driver. > gpio pins are used to control power to an external OTG device and > an override to turn vbus on/off. > Note: the R-Car USB PHY only allows this Host/Function switching > on channel 0. > This has been tested on a r8a7791 based Koelsch board, which uses > a MAX3355 device to supply vbus power when needed. > Signed-off-by: Phil Edworthy I'm inclined to NAK this. You're modifying the wrong driver, I think. WBR, Sergei