linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH/RFC 05/10] arm64: dts: r8a7795: add clock for EthernetAVB
Date: Thu, 27 Aug 2015 10:44:54 +0000	[thread overview]
Message-ID: <55DEEA26.9080002@cogentembedded.com> (raw)
In-Reply-To: <1440667450-3513-6-git-send-email-horms+renesas@verge.net.au>

On 8/27/2015 12:24 PM, Simon Horman wrote:

> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>
> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> [horms: updated p_clk to s3d4_clk; moved to clock node; updated changelog;
>          use R8A7795 as prefix for clock defines]
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>   arch/arm64/boot/dts/renesas/r8a7795.dtsi  | 11 +++++++++++
>   include/dt-bindings/clock/r8a7795-clock.h |  1 +
>   2 files changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> index a608eb92a172..0b435d8274e4 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> @@ -227,6 +227,16 @@
>   					clock-output-names = "hsusb", "ehci0", "ehci1", "ehci2";
>   				};
>
> +				mstp8_clks: mstp8_clks@e6150990 {
> +					compatible = "renesas,r8a7795-mstp-clocks",
> +						     "renesas,cpg-mstp-clocks";
> +					reg = <0 0xe6150990 0 4>, <0 0xe61509a0 0 4>;
> +					clocks =  <&s3d4_clk>;
> +					#clock-cells = <1>;
> +					renesas,clock-indices = <R8A7795_CLK_AVB>;

    I thought there is standard generic property for that now, no?

> +					clock-output-names = "avb";
> +				};
> +
>   				mstp9_clks: mstp9_clks@e6150994 {
>   					compatible = "renesas,r8a7795-mstp-clocks",
>   						     "renesas,cpg-mstp-clocks";
> @@ -352,4 +362,5 @@
>   			status = "disabled";
>   		};
>   	};
> +
>   };

    Stray newline?

[...]

MBR, Sergei


  reply	other threads:[~2015-08-27 10:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-27  9:24 [PATCH/RFC 05/10] arm64: dts: r8a7795: add clock for EthernetAVB Simon Horman
2015-08-27 10:44 ` Sergei Shtylyov [this message]
2015-08-27 11:11 ` Geert Uytterhoeven
2015-08-27 23:47 ` Kuninori Morimoto
2015-08-28  2:23 ` Simon Horman
2015-08-28  2:23 ` Simon Horman
2015-08-28  7:42 ` Geert Uytterhoeven
2015-09-02  2:01 ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55DEEA26.9080002@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).